Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751319AbVLILt4 (ORCPT ); Fri, 9 Dec 2005 06:49:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751316AbVLILtz (ORCPT ); Fri, 9 Dec 2005 06:49:55 -0500 Received: from havoc.gtf.org ([69.61.125.42]:53889 "EHLO havoc.gtf.org") by vger.kernel.org with ESMTP id S1750708AbVLILty (ORCPT ); Fri, 9 Dec 2005 06:49:54 -0500 Date: Fri, 9 Dec 2005 06:49:44 -0500 From: Jeff Garzik To: Christoph Hellwig , Matthew Garrett , Alan Cox , randy_d_dunlap@linux.intel.com, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, acpi-devel@lists.sourceforge.net Subject: Re: RFC: ACPI/scsi/libata integration and hotswap Message-ID: <20051209114944.GA1068@havoc.gtf.org> References: <20051208091542.GA9538@infradead.org> <20051208132657.GA21529@srcf.ucam.org> <20051208133308.GA13267@infradead.org> <20051208133945.GA21633@srcf.ucam.org> <1134050498.17102.2.camel@localhost.localdomain> <20051208141811.GB21715@srcf.ucam.org> <1134052433.17102.17.camel@localhost.localdomain> <20051208145257.GB21946@srcf.ucam.org> <20051208171901.GA22451@srcf.ucam.org> <20051209114246.GB16945@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051209114246.GB16945@infradead.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1580 Lines: 42 On Fri, Dec 09, 2005 at 11:42:46AM +0000, Christoph Hellwig wrote: > On Thu, Dec 08, 2005 at 05:19:01PM +0000, Matthew Garrett wrote: > > This turns out to be quite difficult, and I can't see a clean way of > > doing it without touching scsi or rewriting chunks of the ACPI glue > > code. > > > > The basic flow of code required here is: > > > > 1) scsi layer registers a new device > > 2) platform_notify is called, which is (in this case) > > acpi_platform_notify > > 3) acpi_platform_notify checks whether it knows dev->bus. If so, it > > calls appropriate callbacks. > > > > Without touching scsi, there doesn't seem to be any way for (3) to work > > if scsi is a module. Would a simple > > > > #ifdef CONFIG_ACPI > > acpi_scsi_init(&scsi_bus_type) > > #endif > > > > in the scsi code be acceptable? If not, then we have some difficulty. > > The acpi glue code has to be statically linked in, so it can't rely on > > anything that directly references the scsi code. > > As a concept it's _much_ better. Although it should be platform_scsi_init > and every architecture would provide an, in most cases noop, implementation. If this is just for libata, it's still at the wrong level. libata will eventually make the SCSI simulator optional, which means any acpi_scsi_init() or whatnot won't work for libata. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/