Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp5859105ybi; Wed, 31 Jul 2019 04:30:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZuXVkn9yrUG1MyHnmzvLr3ifagH8QiQOGbUXlX+HDD4IA6vBtOc3m3xMzhPyC8jXHad0g X-Received: by 2002:a62:b515:: with SMTP id y21mr47836900pfe.213.1564572652799; Wed, 31 Jul 2019 04:30:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564572652; cv=none; d=google.com; s=arc-20160816; b=b+5givkiah+uS4VkMhe2wH1SfPcxcQUbLuWjAOhnI30RRv7WofFUoEV04QNL3auVrh SphhVWDfFdpKcDLatMwWC9zeq+b9w9M3rhznXUfigXAicU+wiNosuMBl8wBeYcHYtb7m 6XOseuQ2tNiLKliZMw71XaYGquqa7WcvRjxzo9Ga16X/Q445DesjI579LBK3WZ/Z3O+1 kAVqaV5lxGhXvl5Qr5RuC5uXJwqAelMcYaOF6FGm7AmI/4fgConnnoxVtDxGjJ/FVaYp 01JGdImmdx7WsZHf/ooSd2GYAn94+ZXDeXm20NKVMvfDcl1NpoQ6L+qGGEZAkF7MUopL b9UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=VJaVOw5ddrpPVBmtAcW72u0VL/zZeaiW9sVlqG7m/Kw=; b=Me4si+5D42/M/5lNE1SglsBh4PBF5VyE/LXuxeowvimbI8CudF4qkOCp7lsS0HEIhb ba8X5uAGDrvLzvY0Z971cNh0dpIm+cmF8lp7gW3tpMGUu+/q1/1FDc7H8elpGVgE4NgZ LR0qezKL++G2fGma1SNc0r9RR99RvmBC7z87lHj5IQSPJ1+s9uwIexgWPTFkkVJAGQyV OVSSvVQOQqK/VJyf3pF/6PfVdH5U5Y4J4e3T5dLPX2ldeSRs5abyKaGDn5OfJVnSuTe4 5mVe+qj4TKUPafXkVsehLJFhbraveX8htLSujhsykMYVS70EIffqUr5WCt5TQf8Nu6Z8 W0mQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14si36528097pgi.513.2019.07.31.04.30.38; Wed, 31 Jul 2019 04:30:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbfGaK7b (ORCPT + 99 others); Wed, 31 Jul 2019 06:59:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:40780 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725921AbfGaK7a (ORCPT ); Wed, 31 Jul 2019 06:59:30 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BA844ACC4; Wed, 31 Jul 2019 10:59:29 +0000 (UTC) Date: Wed, 31 Jul 2019 12:59:27 +0200 From: Petr Vorel To: YueHaibing Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices() Message-ID: <20190731105927.GA5092@dell5510> Reply-To: Petr Vorel References: <20190725145719.8344-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190725145719.8344-1-yuehaibing@huawei.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > In delayedwork_callback(), logi_dj_recv_query_paired_devices > may return positive value while success now, so check it > correctly. > Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices") > Signed-off-by: YueHaibing Reviewed-by: Petr Vorel Kind regards, Petr