Message-Id: <439989A7.76F0.0078.0@novell.com>
Date: Fri, 09 Dec 2005 13:41:59 +0100
From: "Jan Beulich" <JBeulich@novell.com>
To: "Rafael Wysocki" <rjw@sisk.pl>
Cc: "Andrew Morton" <akpm@osdl.org>, "Andi Kleen" <ak@suse.de>,
       <linux-kernel@vger.kernel.org>, <discuss@x86-64.org>
Subject: Re: 2.6.15-rc5-mm1 (x86_64-hpet-overflow.patch breaks resume
	from disk)
References: <20051204232153.258cd554.akpm@osdl.org>  <200512082335.50417.rjw@sisk.pl>  <43995957.76F0.0078.0@novell.com> <200512091220.06060.rjw@sisk.pl>
In-Reply-To: <200512091220.06060.rjw@sisk.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 994
Lines: 31

>>> "Rafael J. Wysocki" <rjw@sisk.pl> 09.12.05 12:20:05 >>>
>On Friday, 9 December 2005 10:15, Jan Beulich wrote:
>> It's a possible way to address this, but I'd rather just set a flag
>> indicating that the last-whatever values should not be considered
(to
>> get into a state just like after initial boot). Jan
>
>OK, but what is the interrupt handler supposed to do if the
>vxtime.last* values are invalid?  I guess assume delta = 0?

As I said, the state should be (re)set to whatever is in effect at
boot.

>BTW, in the interrupt handler there is:
>
>		__asm__("mulq %1\n\t"
>		        "shrdq $32, %%rdx, %0"
>		        : "+a" (delta)
>		        : "rm" (vxtime.tsc_quot)
>		        : "rdx");
>
>Is the "+a" a typo?

Why would you think so?

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/