Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp5949228ybi; Wed, 31 Jul 2019 05:59:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqy26rQTBiLl/j4UpEuWWVWS9c9MLs/Sjnjv2NBH4UhoPTXm3ExVmNunVbGh9RSgb4san/HH X-Received: by 2002:a17:902:ac85:: with SMTP id h5mr121749949plr.198.1564577998323; Wed, 31 Jul 2019 05:59:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564577998; cv=none; d=google.com; s=arc-20160816; b=WDM6M9DmDmtTOzk31J6nHzh42c0KDMG0NX0q8xwmCNLV3/8NIX0M2PLGeikOMkQLQe 2zMn5PkQNu/lD2kXR84PT8ZUD8ElPRCchSZZ/Nqchu2xRy2vIEMTNJ4n2lG7H6/dO+vZ SQ7SZFOQsVPrEZEnZg2r97QNpzP0sCrejG6HxDCn4aD3NAPhK/ygSLbDvEJW+iHAm1C5 HXMsFjvP7A7p67bEUf5xIPyC3GbwNF6tS2uS73vC+lacQ9ByGiVX5y7uD2JHBlRP7gt5 PiRat78eEF4lyzcg3y/EHVDZsZazSXuoxDr+1h6gxCzZRitbe5MHESy9dQ1/K3ZMSA8I T24Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=NGyHN72XfFxcu0ubllHDiuQBiRWB06bm3uikDzzR8EU=; b=oo3BzYeuYs2l+eRM2rrXDzT9dz8QBozpANWZj5aVM5Mi4n+Iix/km3JM6yqWrHS3Lq RHTdM/wBZsDZGsjndbgJVDhUb5BkrU4sOURK//iLC8O2weIfMM+cRMzIXxwAnl370QGN H2K1DTGcmdAtPx9VpUdWzg9Tv/Smnk6dXIaL9Z4EEhmVNakA8Xs0LBeJPS4qSdyBCWLe FSF2XFzPF+O5XeeZQenmGfAqb7iP/wR0UsqWSJ6+ohaczGaSguBsnhFVyXoItZuCQ0wL tbTx+7Mh2551eBfalF1HO2BxuETXt6I7LJf08aFlY1I6FV6tLIQweRaKeqs11bx66N30 RzXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9si34087379pgv.577.2019.07.31.05.59.43; Wed, 31 Jul 2019 05:59:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729077AbfGaMu6 (ORCPT + 99 others); Wed, 31 Jul 2019 08:50:58 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:38514 "EHLO michel.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbfGaMu5 (ORCPT ); Wed, 31 Jul 2019 08:50:57 -0400 Received: from ramsan ([84.194.98.4]) by michel.telenet-ops.be with bizsmtp id jQqv2000C05gfCL06Qqv77; Wed, 31 Jul 2019 14:50:55 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1hso4F-0000cX-Fr; Wed, 31 Jul 2019 14:50:55 +0200 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1hso4F-0003qe-Dl; Wed, 31 Jul 2019 14:50:55 +0200 From: Geert Uytterhoeven To: Zhang Rui , Eduardo Valentin , Daniel Lezcano Cc: Marek Vasut , linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] thermal: rcar_gen3_thermal: Use devm_add_action_or_reset() helper Date: Wed, 31 Jul 2019 14:50:53 +0200 Message-Id: <20190731125053.14750-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the devm_add_action_or_reset() helper instead of open-coding the same operations. Signed-off-by: Geert Uytterhoeven --- drivers/thermal/rcar_gen3_thermal.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index a56463308694e937..2db7e7f8baf939fd 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -443,11 +443,10 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) if (ret) goto error_unregister; - ret = devm_add_action(dev, rcar_gen3_hwmon_action, zone); - if (ret) { - rcar_gen3_hwmon_action(zone); + ret = devm_add_action_or_reset(dev, rcar_gen3_hwmon_action, + zone); + if (ret) goto error_unregister; - } ret = of_thermal_get_ntrips(tsc->zone); if (ret < 0) -- 2.17.1