Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp5980796ybi; Wed, 31 Jul 2019 06:27:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqy6bZqExy7NOzhCmzqr/eKU/RuMzRtwhgtAFCn5PRkTnM1UbanYKMZBYs4U3TzapMb3Ez15 X-Received: by 2002:a17:90a:c588:: with SMTP id l8mr3038036pjt.16.1564579620738; Wed, 31 Jul 2019 06:27:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564579620; cv=none; d=google.com; s=arc-20160816; b=N0tQTB+kH6TMqh3uGQ7gtQxYdF0kgmRH0IH4WTlR3sqcNj3fhGic+McYq/1EKe3CN+ kHdqRtBDlGUOu6CxLoBCRtElvX8N7XOasSaCwim/eUvu34NHVDJGsVnHM4n1XS23cuOw 6E0FrCq40wOFVSXtNcwgy3xvvDOB5/yTdediYi4Lq2FyP13Lf4brRry+bRSe+tUxFBGz wdfD9Vugj8PElmKq3wFEzxwOm3GxxXS3hIoml1fGxGlNdjYJFYHwhCwGh07fX0NF6TnL t57ugiiELvnPB24d+Z8GXbPx2Qtqkd7k+2H20kZWlIrwICVP9sXUC3paTv7HaErBcqfz c69A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:importance:content-transfer-encoding :mime-version:subject:references:in-reply-to:message-id:cc:to:from :date; bh=lEAIrBddVvJRByIxjH9Ll8q09EpZFx/70n2AETy6e/g=; b=pP3Bi8b7njIYkG22fYPcPDgkeuokEdDuhzUP7kz2SICizeGI/xOMuFsg4zi0KRQ10U o9419/nlLNJbuGchyBvEtIBAaVoiWfg3p1NRDVv0uXzg4P3hrPxNdjjQD10kkRTVhPtc /n7Sh2jmfC4DIXwKmUacWkhpg83Ld1V4KTZz/cUFYwtykqZDsa2j/7ZoAkrpKD6195/Z uec/q8sFP3YXvty8MM2vC32ADOZU0YF4kntVb+yJMDxcyfaI+vMKTk4ETeTK0wii4wT1 R051qiLxtBVi5v//2Xn0ybDhjRMTAkUELPB53FTR/S4N4Ck7zYQhIpCM6uvn4y+3kVpR 0LRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t35si5949534pgm.8.2019.07.31.06.26.45; Wed, 31 Jul 2019 06:27:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387927AbfGaNYf (ORCPT + 99 others); Wed, 31 Jul 2019 09:24:35 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.52]:34446 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726259AbfGaNYf (ORCPT ); Wed, 31 Jul 2019 09:24:35 -0400 X-RZG-AUTH: ":OWANVUa4dPFUgKR/3dpvnYP0Np73amq+g13rqGzmt2bYDnKIKaws6YXTsc4=" X-RZG-CLASS-ID: mo00 Received: from oxapp06-03.back.ox.d0m.de by smtp-ox.front (RZmta 44.24 AUTH) with ESMTPSA id h0a328v6VDOWZRD (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 31 Jul 2019 15:24:32 +0200 (CEST) Date: Wed, 31 Jul 2019 15:24:32 +0200 (CEST) From: Ulrich Hecht To: Geert Uytterhoeven , Greg Kroah-Hartman , Jiri Slaby Cc: Joe Perches , Ulrich Hecht , linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <625990202.318842.1564579472697@webmail.strato.com> In-Reply-To: <20190731124555.14349-1-geert+renesas@glider.be> References: <20190731124555.14349-1-geert+renesas@glider.be> Subject: Re: [PATCH] serial: sh-sci: Use DEVICE_ATTR_RW() for rx_fifo_trigger MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.10.1-Rev16 X-Originating-IP: 85.212.153.30 X-Originating-Client: open-xchange-appsuite Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On July 31, 2019 at 2:45 PM Geert Uytterhoeven wrote: > > > While commit b6b996b6cdeecf7e ("treewide: Use DEVICE_ATTR_RW") converted > the rx_fifo_timeout attribute, it forgot to convert rx_fifo_trigger due > to a slightly different function naming. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/tty/serial/sh-sci.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c > index d18c680aa64b3427..57638175639e0f3f 100644 > --- a/drivers/tty/serial/sh-sci.c > +++ b/drivers/tty/serial/sh-sci.c > @@ -1092,9 +1092,8 @@ static void rx_fifo_timer_fn(struct timer_list *t) > scif_set_rtrg(port, 1); > } > > -static ssize_t rx_trigger_show(struct device *dev, > - struct device_attribute *attr, > - char *buf) > +static ssize_t rx_fifo_trigger_show(struct device *dev, > + struct device_attribute *attr, char *buf) > { > struct uart_port *port = dev_get_drvdata(dev); > struct sci_port *sci = to_sci_port(port); > @@ -1102,10 +1101,9 @@ static ssize_t rx_trigger_show(struct device *dev, > return sprintf(buf, "%d\n", sci->rx_trigger); > } > > -static ssize_t rx_trigger_store(struct device *dev, > - struct device_attribute *attr, > - const char *buf, > - size_t count) > +static ssize_t rx_fifo_trigger_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > { > struct uart_port *port = dev_get_drvdata(dev); > struct sci_port *sci = to_sci_port(port); > @@ -1123,7 +1121,7 @@ static ssize_t rx_trigger_store(struct device *dev, > return count; > } > > -static DEVICE_ATTR(rx_fifo_trigger, 0644, rx_trigger_show, rx_trigger_store); > +static DEVICE_ATTR_RW(rx_fifo_trigger); > > static ssize_t rx_fifo_timeout_show(struct device *dev, > struct device_attribute *attr, > -- > 2.17.1 > Reviewed-by: Ulrich Hecht CU Uli