Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 31 Jul 2019 07:58:37 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Changbin Du <changbin.du@gmail.com>
Cc:     Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fgraph: Remove redundant ftrace_graph_notrace_addr()
 test
Message-ID: <20190731075837.6d2a3995@gandalf.local.home>
In-Reply-To: <20190731103143.ear4erai6yvt4ct6@mail.google.com>
References: <20190730140850.7927-1-changbin.du@gmail.com>
        <20190730121527.13f600f5@gandalf.local.home>
        <20190731103143.ear4erai6yvt4ct6@mail.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 31 Jul 2019 18:31:45 +0800
Changbin Du <changbin.du@gmail.com> wrote:

> On Tue, Jul 30, 2019 at 12:15:27PM -0400, Steven Rostedt wrote:
> > On Tue, 30 Jul 2019 22:08:50 +0800
> > Changbin Du <changbin.du@gmail.com> wrote:
> >   
> > > We already have tested it before. The second one should be removed.
> > > With this change, the performance should have little improvement.
> > > 
> > > Fixes: 9cd2992f2d6c ("fgraph: Have set_graph_notrace only affect function_graph tracer")  
> > 
> > Thanks! I think this should even be marked for stable. Not really a bad
> > bug, but a bug none the less.
> >  
> Steven, need I resend this patch and cc stable mailist?
> 

No.

I actually already pulled it in and ran it through my tests. I'm
waiting on some more tests before pushing it off to Linus.

-- Steve