Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp6048507ybi; Wed, 31 Jul 2019 07:32:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0xRg0fBdUteiGfXKZ4qmUaDsHpaZNVA654Y9aZNKD2mwaUwoNqo5O+Q0FFkPPfGzaOan6 X-Received: by 2002:a17:902:5ac4:: with SMTP id g4mr123664831plm.80.1564583557857; Wed, 31 Jul 2019 07:32:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564583557; cv=none; d=google.com; s=arc-20160816; b=gY1Sp3GFxbiBZUhJ9hYjpnpBKNcqB45uSUb2DvfNwH8RmN83XsGTeb1amZ17Ks+XGC JhE7A/bV/1OOc8WhOyJTR08yiXTRAdRy2yO9gqWHG/xjMhLWVcj8AN3i0+FixjeAUtxB 4X/KJ8myWR40ixTVUibQi9tgxK2hjyqhbjsxbaUlgt3BqPpbGVAWqLNzBFQBmQ4Hp6YA YkaQPXptSMPdCupfe3+MGAy6wsif0X4F2k1g+7thl1XtlrczHgcwlC2m3VaAret0ud4s i642kfjjxDSQKJaSjHMiWMO/30z9A/Ss4fiMSDbdKpbZaDuc3X7Qwzeqs1QRpmibX/MP Htbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WwRlo3lFbRtJvnPj61pTIoGr4i4Jytx27iSEIiwUFp0=; b=xJpv2VXegt/ZT1nJ1hE/JOn5FrgSVF6qebJ1efP/WGrc4wMVGCI3ssHlPseAdRpmbA vDqXf02pCxqch2FWy7GUwmyjytOe2qBXuwVMBDe46/TOZv//cmJva3MmjNHu6pXzCwW/ zjhYK5lReNuab83Vxea6xZdHANPPlCY4HFhluIN9r4XPlJiiZBXGb6CyBTttN9mQ+6bd raHsnmlhoC/W4o25LewEZNlRvciGrxWP1TW3/3LFLL+CzHhzwl0JFx+KX85YVi7ailp9 NLS9mKSfG1vBd0x9IsY8N+OuQiBtGVv1oUbrmRPih/csunrX9b97m7FoZa8Un3M6uR0d TmMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XFEeDO7G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q16si32939278pgv.140.2019.07.31.07.32.22; Wed, 31 Jul 2019 07:32:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XFEeDO7G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388044AbfGaMoT (ORCPT + 99 others); Wed, 31 Jul 2019 08:44:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:36636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbfGaMoQ (ORCPT ); Wed, 31 Jul 2019 08:44:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B0692089E; Wed, 31 Jul 2019 12:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564577055; bh=iNW8wNE5JHBZzgakkExMWkpVXk60TdQED+PTGb/g0pk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XFEeDO7GXMu8iFGWL3oPbd2aUKaueXO6WY/Y974vTpcBTA24h+pXl5qA8wo3dT2vt ctIKOx/+vIIwU8/IyHDhl43bxXiL8TCEJqKd+84WYwRVtH7kQsX97BB8ERfD8OuU8H boNTRZI86fCLVV+vdc2rsW1XJdOJ8pcHjwYasdpc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, Richard Gong , Dmitry Torokhov Cc: Greg Kroah-Hartman , Sudeep Holla , linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 05/10] firmware: arm_scpi: convert platform driver to use dev_groups Date: Wed, 31 Jul 2019 14:43:44 +0200 Message-Id: <20190731124349.4474-6-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190731124349.4474-1-gregkh@linuxfoundation.org> References: <20190731124349.4474-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Platform drivers now have the option to have the platform core create and remove any needed sysfs attribute files. So take advantage of that and do not register "by hand" a sysfs group of attributes. Acked-by: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/arm_scpi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c index 725164b83242..a80c331c3a6e 100644 --- a/drivers/firmware/arm_scpi.c +++ b/drivers/firmware/arm_scpi.c @@ -1011,10 +1011,6 @@ static int scpi_probe(struct platform_device *pdev) scpi_info->firmware_version)); scpi_info->scpi_ops = &scpi_ops; - ret = devm_device_add_groups(dev, versions_groups); - if (ret) - dev_err(dev, "unable to create sysfs version group\n"); - return devm_of_platform_populate(dev); } @@ -1030,6 +1026,7 @@ static struct platform_driver scpi_driver = { .driver = { .name = "scpi_protocol", .of_match_table = scpi_of_match, + .dev_groups = versions_groups, }, .probe = scpi_probe, .remove = scpi_remove, -- 2.22.0