Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 31 Jul 2019 20:46:10 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     Sameer Pujar <spujar@nvidia.com>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>,
        dan.j.williams@intel.com, tiwai@suse.com,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        sharadg@nvidia.com, rlokhande@nvidia.com, dramesh@nvidia.com,
        mkumard@nvidia.com
Subject: Re: [PATCH] [RFC] dmaengine: add fifo_size member
Message-ID: <20190731151610.GT12733@vkoul-mobl.Dlink>
References: <09929edf-ddec-b70e-965e-cbc9ba4ffe6a@nvidia.com>
 <20190618043308.GJ2962@vkoul-mobl>
 <23474b74-3c26-3083-be21-4de7731a0e95@nvidia.com>
 <20190624062609.GV2962@vkoul-mobl>
 <e9e822da-1cb9-b510-7639-43407fda8321@nvidia.com>
 <75be49ac-8461-0798-b673-431ec527d74f@nvidia.com>
 <20190719050459.GM12733@vkoul-mobl.Dlink>
 <3e7f795d-56fb-6a71-b844-2fc2b85e099e@nvidia.com>
 <20190729061010.GC12733@vkoul-mobl.Dlink>
 <98954eb3-21f1-6008-f8e1-f9f9b82f87fb@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <98954eb3-21f1-6008-f8e1-f9f9b82f87fb@nvidia.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 31-07-19, 10:48, Jon Hunter wrote:
> 
> On 29/07/2019 07:10, Vinod Koul wrote:
> > On 23-07-19, 11:24, Sameer Pujar wrote:
> >>
> >> On 7/19/2019 10:34 AM, Vinod Koul wrote:
> >>> On 05-07-19, 11:45, Sameer Pujar wrote:
> >>>> Hi Vinod,
> >>>>
> >>>> What are your final thoughts regarding this?
> >>> Hi sameer,
> >>>
> >>> Sorry for the delay in replying
> >>>
> >>> On this, I am inclined to think that dma driver should not be involved.
> >>> The ADMAIF needs this configuration and we should take the path of
> >>> dma_router for this piece and add features like this to it
> >>
> >> Hi Vinod,
> >>
> >> The configuration is needed by both ADMA and ADMAIF. The size is
> >> configurable
> >> on ADMAIF side. ADMA needs to know this info and program accordingly.
> > 
> > Well I would say client decides the settings for both DMA, DMAIF and
> > sets the peripheral accordingly as well, so client communicates the two
> > sets of info to two set of drivers
> 
> That maybe, but I still don't see how the information is passed from the
> client in the first place. The current problem is that there is no means
> to pass both a max-burst size and fifo-size to the DMA driver from the
> client.

So one thing not clear to me is why ADMA needs fifo-size, I thought it
was to program ADMAIF and if we have client programme the max-burst
size to ADMA and fifo-size to ADMAIF we wont need that. Can you please
confirm if my assumption is valid?

> IMO there needs to be a way to pass vendor specific DMA configuration
> (if this information is not common) otherwise we just end up in a
> scenario like there is for the xilinx DMA driver
> (include/linux/dma/xilinx_dma.h) that has a custom API for passing this
> information.
> 
> Cheers
> Jon
> 
> -- 
> nvpublic

-- 
~Vinod