Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/3] KVM: Don't need to wakeup vCPU twice afer timer fire
To:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <kernellwp@gmail.com>
Cc:     =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
References: <1564572438-15518-1-git-send-email-wanpengli@tencent.com>
 <ab8f8b07-e3f9-4831-c386-0bfa0314f9c3@redhat.com>
 <87imri73dp.fsf@vitty.brq.redhat.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Openpgp: preference=signencrypt
Message-ID: <a3c6d25e-8ede-695d-8f2d-632799c5fb1c@redhat.com>
Date:   Wed, 31 Jul 2019 18:39:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <87imri73dp.fsf@vitty.brq.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 31/07/19 15:14, Vitaly Kuznetsov wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
>> On 31/07/19 13:27, Wanpeng Li wrote:
>>> From: Wanpeng Li <wanpengli@tencent.com>
>>>
>>> kvm_set_pending_timer() will take care to wake up the sleeping vCPU which 
>>> has pending timer, don't need to check this in apic_timer_expired() again.
>>
>> No, it doesn't.  kvm_make_request never kicks the vCPU.
>>
> 
> Hm, but kvm_set_pending_timer() currently looks like:
> 
> void kvm_set_pending_timer(struct kvm_vcpu *vcpu)
> {
> 	kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu);
> 	kvm_vcpu_kick(vcpu);
> }

Doing "git fetch" could have helped indeed.

Paolo