Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp6248517ybi; Wed, 31 Jul 2019 10:52:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLVA/R+KqENcA1KYCxLtzZu4awyE9AU1B2HGclm4gRbVjWCjJVx/cpsEiDnrIDTUpE5kEX X-Received: by 2002:a17:902:f46:: with SMTP id 64mr122642938ply.235.1564595573380; Wed, 31 Jul 2019 10:52:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564595573; cv=none; d=google.com; s=arc-20160816; b=qEEJ5moESIF6ExIWUwiVNpK4QWTBZBSlpbu3E+QQfDDYq0HZYSZAKzCerM6ZrO1+Gq QJqpHoil6wLaABfQ/Fi76OE4sMcGXvQb+4vXBxzcFVbtL7rD5xQw2CtaNE3qt54zP1Gm hg5u9bS5agr9O4YYpZV6EZzpQOzZT9mW4fW5o47I/xNeEp41rdL/bXSoy1dFJls+VZLs 0otfFh6gkAQrbgvpIkONfWeucAcDuC6zEyjOTzW5fDHgY9AKEtd4MazGkwQplcaqDllS sWGfGzaTV6/9/BtOOXMuySbAp5MnAgxJ35lSbWoY+FU9P/UX4GLJs7X9/0R0tLkw8oj0 cxoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=kBRn/NsSMUeeLhFAyGHJpVNXOrTggWkDWAC+9QgWxZE=; b=Abuk4lfxGlVJJb3GbGheFsFv2XhmNg5Tfbkt3lAKZW7G4elvgUNLKtCN84hIQBrZyr lfsN0GWnVX+V8jESXyV3NeAyaRgTu/+4sfu7N/5lEr4/zIfNgkC216UM6tHmKZp+p7D9 AJuALiM3hxDk0Cd5MmKqJoyT7+0QAeOjNq3YmAbin+jcXcSmZwsJEFQ/5yDA4dshuGAR BvddNTNTd+XdpMNE+vchWOzrkYZmBgH8rXEVyKh8bX2YbNPyV0BALmOe/2Cof1FuPaWG jUfaU80+wZKQAxJeLtq9GiqmYnheIg4tNRfQ+fer7s2iF0MU890kigfO+wIYAplbY/hv MvCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si29602438plb.14.2019.07.31.10.52.38; Wed, 31 Jul 2019 10:52:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730309AbfGaRJc (ORCPT + 99 others); Wed, 31 Jul 2019 13:09:32 -0400 Received: from foss.arm.com ([217.140.110.172]:52086 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbfGaRJc (ORCPT ); Wed, 31 Jul 2019 13:09:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9CD78337; Wed, 31 Jul 2019 10:09:31 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B75903F71F; Wed, 31 Jul 2019 10:09:29 -0700 (PDT) Date: Wed, 31 Jul 2019 18:09:27 +0100 From: Catalin Marinas To: Vincenzo Frascino Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, salyzyn@android.com, pcc@google.com, 0x7f454c46@gmail.com, linux@rasmusvillemoes.dk, sthotton@marvell.com, andre.przywara@arm.com, luto@kernel.org, Matteo Croce Subject: Re: [PATCH] arm64: vdso: Fix Makefile regression Message-ID: <20190731170927.GD17773@arrakis.emea.arm.com> References: <20190729125421.32482-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190729125421.32482-1-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 29, 2019 at 01:54:21PM +0100, Vincenzo Frascino wrote: > Using an old .config in combination with "make oldconfig" can cause > an incorrect detection of the compat compiler: > > $ grep CROSS_COMPILE_COMPAT .config > CONFIG_CROSS_COMPILE_COMPAT_VDSO="" > > $ make oldconfig && make > arch/arm64/Makefile:58: gcc not found, check CROSS_COMPILE_COMPAT. > Stop. > > Accordingly to the section 7.2 of the GNU Make manual "Syntax of > Conditionals", "When the value results from complex expansions of > variables and functions, expansions you would consider empty may > actually contain whitespace characters and thus are not seen as > empty. However, you can use the strip function to avoid interpreting > whitespace as a non-empty value." > > Fix the issue adding strip to the CROSS_COMPILE_COMPAT string > evaluation. > > Cc: Will Deacon > Cc: Catalin Marinas > Reported-by: Matteo Croce > Signed-off-by: Vincenzo Frascino Queued for 5.3-rc3. Thanks. -- Catalin