Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964799AbVLIRI2 (ORCPT ); Fri, 9 Dec 2005 12:08:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964802AbVLIRI1 (ORCPT ); Fri, 9 Dec 2005 12:08:27 -0500 Received: from e6.ny.us.ibm.com ([32.97.182.146]:1941 "EHLO e6.ny.us.ibm.com") by vger.kernel.org with ESMTP id S964799AbVLIRI1 (ORCPT ); Fri, 9 Dec 2005 12:08:27 -0500 Subject: Re: [PATCH 2.6.15-rc5] hugetlb: make make_huge_pte global and fix coding style From: Adam Litke To: Mark Rustad Cc: linux-kernel@vger.kernel.org In-Reply-To: References: Content-Type: text/plain Date: Fri, 09 Dec 2005 11:05:43 -0600 Message-Id: <1134147943.25408.36.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 22 On Fri, 2005-12-09 at 10:39 -0600, Mark Rustad wrote: > This patch makes the function make_huge_pte non-static, so it can be used > by drivers that want to mmap huge pages. Consequently, a prototype for the > function is added to hugetlb.h. Since I was looking here, I noticed some > coding style problems in the function and fix them with this patch. > > Signed-off-by: Mark Rustad Call me crazy, but I cringe when I think of any old driver directly mucking with huge_ptes. Forgive me if I am missing something, but why can't you just call do_mmap with a hugetlbfs file like everyone else? Otherwise, the CodingStyle cleanups look alright. -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/