Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 31 Jul 2019 17:22:19 -0300
From:   Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To:     Jonathan Corbet <corbet@lwn.net>
Cc:     Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@infradead.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] docs: fs: convert porting to ReST
Message-ID: <20190731172219.2f07d420@coco.lan>
In-Reply-To: <20190731141707.6f3d21d7@lwn.net>
References: <cover.1564603513.git.mchehab+samsung@kernel.org>
        <a2303fe9fa2103e7d1f8589e1f91a7d65497e8b7.1564603513.git.mchehab+samsung@kernel.org>
        <20190731141707.6f3d21d7@lwn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Wed, 31 Jul 2019 14:17:07 -0600
Jonathan Corbet <corbet@lwn.net> escreveu:

> On Wed, 31 Jul 2019 17:08:52 -0300
> Mauro Carvalho Chehab <mchehab+samsung@kernel.org> wrote:
> 
> > This file has its own proper style, except that, after a while,
> > the coding style gets violated and whitespaces are placed on
> > different ways.
> > 
> > As Sphinx and ReST are very sentitive to whitespace differences,
> > I had to opt if each entry after required/mandatory/... fields
> > should start with zero spaces or with a tab. I opted to start them
> > all from the zero position, in order to avoid needing to break lines
> > with more than 80 columns, with would make harder for review.
> > 
> > Most of the other changes at porting.rst were made to use an unified
> > notation with works nice as a text file while also produce a good html
> > output after being parsed.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > ---
> >  Documentation/filesystems/porting.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
> > index 66aa521e6376..f18506083ced 100644
> > --- a/Documentation/filesystems/porting.rst
> > +++ b/Documentation/filesystems/porting.rst
> > @@ -158,7 +158,7 @@ Callers of notify_change() need ->i_mutex now.
> >  New super_block field ``struct export_operations *s_export_op`` for
> >  explicit support for exporting, e.g. via NFS.  The structure is fully
> >  documented at its declaration in include/linux/fs.h, and in
> > -Documentation/filesystems/nfs/Exporting.
> > +Documentation/filesystems/nfs/exporting.rst.
> >  
> >  Briefly it allows for the definition of decode_fh and encode_fh operations
> >  to encode and decode filehandles, and allows the filesystem to use  
> 
> This patch doesn't match the changelog at all.  I think it's one leftover
> fix after the previous version of the patch was applied...?

Gah, sorry. Yeah, you're right: this is just a fixup patch.

> 
> jon


Thanks,
Mauro