Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp6413187ybi; Wed, 31 Jul 2019 14:01:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzqJONI4D9IR3zYBcRwjubiaoxUSMf3wdVq1s7ubO7Z+70giCKJlRqTHfR1nPzGBw6POi1 X-Received: by 2002:a17:90a:ab0d:: with SMTP id m13mr4571264pjq.84.1564606871656; Wed, 31 Jul 2019 14:01:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564606871; cv=none; d=google.com; s=arc-20160816; b=TncvzBILmllDjz1MsxUJPZYdPeGdNmlBts9uudWDdSfKxeXrEiqt1hI6C03JKBd5vV 1Ak50MUuv15GverYD5Eh6F/6vyL58h+MDH2ezRv7u8TxsqRPT+RgnhCjUdFhcbRCLMd1 kr/MgVhxVw+diEwB8Lt7zJbgT1bJojF1uSsF4h3vi0tA48xalLCUzvn00KQUMDdguG2f XBDR6/8pxaVqq+kSnF9x47Dj8GoeCOwhbFDUpAsi4e37ecu3TywEbs7k+KuX7FOvzaul 1q1A7L6qbo6MF/mFvHNqvPN70lvN8ixbkFk5Ajw/qIpfV/3kPVn6ik2xaC+vZQcc5TGJ a80A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=PkX642AyXmERWhqABoZRyZPSNpA7sngPdQwjFg5/5C4=; b=hTf0Ph0dP+q/AYGUpL3KISet6mhD9YnUZ+/9TR14lzHPcD7WXxPr5AVj25cJc6uU7h zLm7KtO2vkYs3cc7FGx8dGkbxuMTh6r0Ws3ygBzvBEW4kJ+CMFgPFW3xQHDznLDdqVVG iZOKZzPGpAZ3PZJeVjS5d0/ziUS48ikbctMbMduGBrs+uGoYVlq66KH9UqW2GSaiGi/o Bq1xhdBeT1k4rSmR1ykiscvKJ87dJW9pRmeFvJVcO/Mx9Oew6rVzUbz3S79hlEUyfsov BDtUqVyC5dAfxFyFAyoNCV5XQPQw3WLjju9V/O3Lz11bmWbreiF5YG0Cu+3e+iY8PKfc 7QsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 15si11855730pgu.98.2019.07.31.14.00.55; Wed, 31 Jul 2019 14:01:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729505AbfGaUd2 (ORCPT + 99 others); Wed, 31 Jul 2019 16:33:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:56414 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727872AbfGaUd2 (ORCPT ); Wed, 31 Jul 2019 16:33:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B764AAF84; Wed, 31 Jul 2019 20:33:26 +0000 (UTC) Date: Wed, 31 Jul 2019 15:33:24 -0500 From: Goldwyn Rodrigues To: Shiyang Ruan Cc: linux-xfs@vger.kernel.org, linux-nvdimm@lists.01.org, darrick.wong@oracle.com, linux-kernel@vger.kernel.org, gujx@cn.fujitsu.com, david@fromorbit.com, qi.fuli@fujitsu.com, caoj.fnst@cn.fujitsu.com Subject: Re: [RFC PATCH 0/7] xfs: add reflink & dedupe support for fsdax. Message-ID: <20190731203324.7vjwlejmwpghpvqi@fiona> References: <20190731114935.11030-1-ruansy.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731114935.11030-1-ruansy.fnst@cn.fujitsu.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19:49 31/07, Shiyang Ruan wrote: > This patchset aims to take care of this issue to make reflink and dedupe > work correctly in XFS. > > It is based on Goldwyn's patchsets: "v4 Btrfs dax support" and "Btrfs > iomap". I picked up some patches related and made a few fix to make it > basically works fine. > > For dax framework: > 1. adapt to the latest change in iomap. > > For XFS: > 1. report the source address and set IOMAP_COW type for those write > operations that need COW. > 2. update extent list at the end. > 3. add file contents comparison function based on dax framework. > 4. use xfs_break_layouts() to support dax. Shiyang, I think you used the older patches which does not contain the iomap changes which would call iomap_begin() with two iomaps. I have it in the btrfs-iomap branch and plan to update it today. It is built on v5.3-rcX, so it should contain the changes which moves the iomap code to the different directory. I will build the dax patches on top of that. However, we are making a big dependency chain here :( -- Goldwyn > > > Goldwyn Rodrigues (3): > dax: replace mmap entry in case of CoW > fs: dedup file range to use a compare function > dax: memcpy before zeroing range > > Shiyang Ruan (4): > dax: Introduce dax_copy_edges() for COW. > dax: copy data before write. > xfs: Add COW handle for fsdax. > xfs: Add dedupe support for fsdax. > > fs/btrfs/ioctl.c | 11 ++- > fs/dax.c | 203 ++++++++++++++++++++++++++++++++++++++---- > fs/iomap.c | 9 +- > fs/ocfs2/file.c | 2 +- > fs/read_write.c | 11 +-- > fs/xfs/xfs_iomap.c | 42 +++++---- > fs/xfs/xfs_reflink.c | 84 +++++++++-------- > include/linux/dax.h | 15 ++-- > include/linux/fs.h | 8 +- > include/linux/iomap.h | 6 ++ > 10 files changed, 294 insertions(+), 97 deletions(-) > > -- > 2.17.0 > > > -- Goldwyn