Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp6475761ybi; Wed, 31 Jul 2019 15:17:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqzXFHxiYuEG2xpkUcVOvLcnE9laqfh+6OXqVgAkGZeG5wUl/W7oBaMGySx5x80kI4i5qnPX X-Received: by 2002:aa7:9293:: with SMTP id j19mr51040876pfa.90.1564611445370; Wed, 31 Jul 2019 15:17:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564611445; cv=none; d=google.com; s=arc-20160816; b=frbdnT2c0x5eLTHJ/b9NOM0kesJnamchYQDt7hnyzDpKfcTS3qigMMFJOKIrtSSWgR GBBKAq4nP0G0pesk85wgZR1IroviltxDRNlfQqpDvdKkFw0tz7i7+FedPos7M+17WHpD qCxbQ+zxKrF5lertxxTQnwHVUumzxVr0GOvO7ZO/IQR52rRyyr/ctNVJC7bnEbm4i6i4 9j14PLCXMWmv8ObA6aZeW0bTwG2rnUtP6n9Ik5jPFP4YY7Nfrn+TH+OVdhbkonLtlhiH M/oRLKHrTE+ll1JoVcpU1c+BxcukvJIs5B88eyuxhC5BJQvls6LU9GYqqolty1CHSL1h in1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=DvIle9Z7Le0W/koXErTIOG9PhIMMIXfJqWN4mPJ33BE=; b=mmLmJrp5Jih1hOktG4ZV2tcIsqp890YQrczd5Ua7ezuiYrySoWnHjULPQzUzxKt9yG qAGb70oYdcvUZiP2oO9LNIYnAuiA4/1Fu9Ny83vd7CQFPhteMK2z25Y/rbh141OOkNUs RbsnH0bbXkcCLrjcSc2B03WHY4weWzy06fbIeGCuS13lqL6jRS8xY5srB1KcPIIHBHeg 3LY0+flglLoP1MZJVABqUqddtFRALWd84tXzf9FccSA61hq5pKzxbIPNWKT2opZ1UEKw hPMPvxDquVClFx0ckPLNqAWZSHIc03fzktT3GK/qLab23iCyGNyHkxpUApZtADrcUDP9 j4Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hUxoFsGk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g20si32973865pfh.95.2019.07.31.15.17.10; Wed, 31 Jul 2019 15:17:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hUxoFsGk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728973AbfGaUE6 (ORCPT + 99 others); Wed, 31 Jul 2019 16:04:58 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44081 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbfGaUE6 (ORCPT ); Wed, 31 Jul 2019 16:04:58 -0400 Received: by mail-pg1-f195.google.com with SMTP id i18so32599207pgl.11 for ; Wed, 31 Jul 2019 13:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DvIle9Z7Le0W/koXErTIOG9PhIMMIXfJqWN4mPJ33BE=; b=hUxoFsGkeADYymjGHq5GAFM8PLLF2oTqH90Qwa1lVGomKVeJv3LpYYq908h6tx+NC6 JboSViSFWGOnrHw3eax6eEOT2n+FS9htW1HchWAp3w0jojJ78gsyAANzR8f7TlGgYKbp yQKiR7/Vje+a0p9TBadUOpZtoN9epeDzQlCK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DvIle9Z7Le0W/koXErTIOG9PhIMMIXfJqWN4mPJ33BE=; b=HzB9+yCZrJjbH7Dq9KpGAcXMR1uHMuaaG5cNQLcUJ4Og1263N9cz2qP+Lbl4dWkpRW 2lQP/PphMYxW9q1rDUkCQF5+JbhUo4eFJzDVETvPmkAdE5YOyqMZ1myiQXSYdZ7RJtOI lYFAnpnBHYU5bCztriDT3qGETFg4kj4scoOMgfXWbil4ko0G7dAqZ6fJ/SpJC1sqO/jF qxs+/x1a7gcLo8V+BMF4lTv/DlyGipfds85Mx/1sqs6QNHfErVUxUhwI/i/r5Q1l1mD8 5uLIP/lp1PwtIFnXrkwfbgkZeANu50524BigJXiV09Zl48l2yjqyB7HY70tWERXxSxno MXKQ== X-Gm-Message-State: APjAAAUbod8THQtXmiph/KZvt+btUXHy1I39Spd+x6Hh2DToyZvbP9A0 FhAd3H8wIjuglZPbrO/AEHWktw== X-Received: by 2002:a63:1455:: with SMTP id 21mr71350404pgu.116.1564603497556; Wed, 31 Jul 2019 13:04:57 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g4sm84014438pfo.93.2019.07.31.13.04.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Jul 2019 13:04:56 -0700 (PDT) Date: Wed, 31 Jul 2019 13:04:55 -0700 From: Kees Cook To: Matthew Wilcox Cc: Laura Abbott , Alexander Potapenko , kernel test robot , Linus Torvalds , Christoph Lameter , Masahiro Yamada , "Serge E. Hallyn" , Nick Desaulniers , Kostya Serebryany , Dmitry Vyukov , Sandeep Patil , Randy Dunlap , Jann Horn , Mark Rutland , Marco Elver , Andrew Morton , LKML , LKP , linux-mm@kvack.org Subject: Re: [PATCH] mm: slub: Fix slab walking for init_on_free Message-ID: <201907311304.2AAF454F5C@keescook> References: <20190731193240.29477-1-labbott@redhat.com> <20190731193509.GG4700@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731193509.GG4700@bombadil.infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 12:35:09PM -0700, Matthew Wilcox wrote: > On Wed, Jul 31, 2019 at 03:32:40PM -0400, Laura Abbott wrote: > > Fix this by ensuring the value we set with set_freepointer is either NULL > > or another value in the chain. > > > > Reported-by: kernel test robot > > Signed-off-by: Laura Abbott > > Fixes: 6471384af2a6 ("mm: security: introduce init_on_alloc=1 and init_on_free=1 boot options") Reviewed-by: Kees Cook -- Kees Cook