Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 1 Aug 2019 15:51:30 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Miles Chen <miles.chen@mediatek.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the akpm-current tree
Message-ID: <20190801155130.29a07b1b@canb.auug.org.au>
In-Reply-To: <1564554484.28000.3.camel@mtkswgap22>
References: <20190731161151.26ef081e@canb.auug.org.au>
        <1564554484.28000.3.camel@mtkswgap22>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/cn_2R/.2_9jSH7EOBRcRI.J";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/cn_2R/.2_9jSH7EOBRcRI.J
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Miles,

On Wed, 31 Jul 2019 14:28:04 +0800 Miles Chen <miles.chen@mediatek.com> wro=
te:
>
> On Wed, 2019-07-31 at 16:11 +1000, Stephen Rothwell wrote:
> >=20
> > After merging the akpm-current tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >=20
> > mm/memcontrol.c: In function 'invalidate_reclaim_iterators':
> > mm/memcontrol.c:1160:11: warning: suggest parentheses around assignment=
 used as truth value [-Wparentheses]
> >   } while (memcg =3D parent_mem_cgroup(memcg));
> >            ^~~~~
> >  =20
>=20
> Hi Stephen,
>=20
> Thanks for the telling me this. Sorry for the build warning.=20
> Should I send patch v5 to the mailing list to fix this?=20

You might as well (cc'ing Andrew, of course).

I would suggest finishing that loop like this:

		memcg =3D parent_mem_cgroup(memcg);
	} while (memcg);

rather than adding a set of parentheses.

--=20
Cheers,
Stephen Rothwell

--Sig_/cn_2R/.2_9jSH7EOBRcRI.J
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl1CfeIACgkQAVBC80lX
0GwQowf7BtHd6N/Ql7+u/YSYkputgNQzecVwhI/kvO5/6qYvqqJNRd2sRhcOs6kG
wyZMwf1WJAd8wglrKjvdo0Ib1DXGSUwbYDAIX7QAWCjMetfCnGtGY3bf806rOOEc
Q0ZSgMiuIqYd3JZ1aSCy8kQgQyDWO4BugZwxevrxkhKMhPeJTlL6FeODBOBqvk3s
A0DcoZ9cKZr1gHfzY0qvy2X90hG+3y871kg7sVU0pRF45w8fjIjhNS9F3u9/li1p
VxAEv+xl55NJFvMbbwqNCbjhoD5KjqnhLU7vGQMWh7vBs/AamfUTyQ1dAWCHgt00
G4laLXZuprNoceHSSicDZIX0ncB2Ig==
=HXp9
-----END PGP SIGNATURE-----

--Sig_/cn_2R/.2_9jSH7EOBRcRI.J--