Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp6910430ybi; Thu, 1 Aug 2019 00:11:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxLZkQZaCFgULDW6hIa8gkxEprm81ZiPa88KZlhdnuwTq4hwZKklpKejp+jcfbt32wIPSNj X-Received: by 2002:a17:902:fa2:: with SMTP id 31mr126349430plz.38.1564643505602; Thu, 01 Aug 2019 00:11:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564643505; cv=none; d=google.com; s=arc-20160816; b=FrF0eNe5u3wE4PwQbApdmIpKA6nUO3ALfMgoQsZRdFC0F/CgFBG95tLvi/CbK4UWhW glfCaTATLRzJQhPzlyR1nKf3lVARNrln9XirdZysrpZFjAbB5qnu4E2DiyJC+9GlXpU9 CLzJZ0gPVF4vLybQQ23jd5G0QWd3JNmsKIBE03U3FaL8ClwRjfQy7cwnL+5RsHYduyLP 3ujvYRfWX2Bd8Pp/YEaZj9ii/T+0IOkzbelWizDSvtT75ToglYc/PyRBjXinxLb51imA LiN6m9PGSXgZrkvuW1CXzhLuoeLUogeeIpgTKMCtTQS4nYJTw6m/ZWM7w2UUYcm+niAw d23Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5rgSX443qYNIknuRK5mjRcFxB0+Z6ioWYrvJ8z2faHo=; b=TtJace/0OnrZcAfdZRCy3/+W6GmiV2oDx5pNXrJq3oouZZww4PvDzWZSlztSxrPHT2 L2Vc4ts56loa9xJOpobSxJ5LLOWqhRGh7w2mL5QWTtG5cKx80rf5tcswG0E4Zei/YhOY PfraI9xzewzA+fg1MdApt/Vx24bsiV9FM8nLC68NNNrHqotKvLOg6PgxZzwzjWbn8GvJ 5x7JRPe9+3MRCSd0pbq7XqHAcDZm4leSlQ/WeBiZma/6kDjHADOvANaM2T+4ZlbawllA DXob7flLjlLPxF65ewpPRw29q0+UgFyoiGVBWstYpw4lxRRiyxBRUSYGRVNA/ysa3sNo MR1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nkiUt0Z1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v27si35204618pgn.14.2019.08.01.00.11.30; Thu, 01 Aug 2019 00:11:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nkiUt0Z1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729694AbfHAGTo (ORCPT + 99 others); Thu, 1 Aug 2019 02:19:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:58340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728884AbfHAGTo (ORCPT ); Thu, 1 Aug 2019 02:19:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37B89206A3; Thu, 1 Aug 2019 06:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564640383; bh=yRIp6hN1XexHfmK2LSwOgSihVBEA/pyfHGohPSn8E5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nkiUt0Z15vKj+VQFeQUC1YH2XEATo3cMiOXARIWCnR6nJfWWwqXRUkwGzb2uOr5M3 dttsU/gnyYL3REwhrbQDaMty2GLlG0Tamc7x4QGJi7OWBgTvZXq16opkNIAPAcjSxN VJYYv/VHDpn2rYqxYFwyLXp8EwAOqRtoOuMwquyg= Date: Thu, 1 Aug 2019 08:19:41 +0200 From: Greg KH To: Kalesh Singh Cc: rjw@rjwysocki.net, trong@google.com, trong@android.com, sspatil@google.com, hridya@google.com, kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2] PM/sleep: Expose suspend stats in sysfs Message-ID: <20190801061941.GB4338@kroah.com> References: <20190731050549.GA20809@kroah.com> <20190731212933.23673-1-kaleshsingh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731212933.23673-1-kaleshsingh@google.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 02:29:33PM -0700, Kalesh Singh wrote: > Userspace can get suspend stats from the suspend stats debugfs node. > Since debugfs doesn't have stable ABI, expose suspend stats in > sysfs under /sys/power/suspend_stats. > > Signed-off-by: Kalesh Singh > --- > Changes in v2: > - Added separate show functions for last_failed_* stats, as per Greg > - Updated ABI Documentation This is nice, I didn't even know some of these were in the debugfs entries, so this should be more helpful to people. Reviewed-by: Greg Kroah-Hartman