Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7008666ybi; Thu, 1 Aug 2019 01:49:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxxqSwZaMb26QcCbdV5guAFmEnUu5A2aoqgRgGUW5ItRuUAtAmH3pocW39FyytaGVtWgZAH X-Received: by 2002:a63:2364:: with SMTP id u36mr114051554pgm.449.1564649386173; Thu, 01 Aug 2019 01:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564649386; cv=none; d=google.com; s=arc-20160816; b=wBgM2AwHdlntWxE+XJxGhzLeJhx58as9fBwx5tc17BnfGAwxamqFnUWw66bwBx7Vzd lEyssv3djstmP//6gvxSl4cvehXWZV+PEFXkUhQgCwX5er8EBy+viikJLHyhyApDf58S qlmKaCPDAlGeonlfRHfRqvqjzUPTpGLSKQ/NoEyy0YSaNDJ7joGphYDfUEszFyZZk4E6 mBEA20DQ5136cc1FzRBJNCE3PfsDgx0tgb118qBXMIU0yXkMtloE006Qel7Nw/n1VERD 880DnOVI5jfKFXtCUCJaDcp3G6KVfljlK8hydxyCPuGVrFHqUgM7+NIICTouDKpGEmWl 2MOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=6X04h5YPW3AF6gp9A6a26EKeg0t/UT7mpV1LEA9El6U=; b=dA88IKjVaHLTjJ70tR5Y3MeAcJA15ycth4s9IEHj9w4SILgY1xFLFdXLAnQDvJ9y/A lqI4Z1yKf2n8oK34xzu/I71MZ2KKedJkhQZAbgSllS7UU08VQGCpCCXp5vcWTF49vwDW yv/18Lbapyn8rQxHfHcFJ0CJH28l67dxIP3nlu4JJIEfdGRoDA/9k/nO2ZUGumuwezke giLm5B02iPp7twaaTL7j+ZKj5cHLoCFSTN8f+d+thoqqtswsF+KzRrGMdmJxOor81MPD XhRqy35J6Da1yzEGzmsnbZM1+xLvm2JA8m3XlXBHh8VINuBxhYTGSEREowxs2GA7ewcS +2mQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x22si36633171pfo.255.2019.08.01.01.49.30; Thu, 01 Aug 2019 01:49:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730257AbfHAIsd (ORCPT + 99 others); Thu, 1 Aug 2019 04:48:33 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:34847 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbfHAIsd (ORCPT ); Thu, 1 Aug 2019 04:48:33 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ht6lA-00033w-Vq; Thu, 01 Aug 2019 10:48:28 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ht6l9-00042c-2F; Thu, 01 Aug 2019 10:48:27 +0200 Date: Thu, 1 Aug 2019 10:48:27 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Schrempf Frieder Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Jiri Slaby Subject: Re: [PATCH] serial: imx: Avoid probe failure in case of missing gpiolib Message-ID: <20190801084827.m42ci3amo37hmesi@pengutronix.de> References: <20190801081524.22577-1-frieder.schrempf@kontron.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190801081524.22577-1-frieder.schrempf@kontron.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 01, 2019 at 08:18:05AM +0000, Schrempf Frieder wrote: > From: Frieder Schrempf > > If CONFIG_GPIOLIB is not enabled, mctrl_gpio_init() will return > -ENOSYS and cause the probing of the imx UART to fail. As the > GPIOs are optional, we should continue probing in this case. Is this really still the case? On which version did you hit this problem? I would expect that is gone with d99482673f950817b30caf3fcdfb31179b050ce1 if not earlier. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |