Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964889AbVLIWC3 (ORCPT ); Fri, 9 Dec 2005 17:02:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964891AbVLIWC3 (ORCPT ); Fri, 9 Dec 2005 17:02:29 -0500 Received: from mailout.stusta.mhn.de ([141.84.69.5]:45836 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S964889AbVLIWC2 (ORCPT ); Fri, 9 Dec 2005 17:02:28 -0500 Date: Fri, 9 Dec 2005 23:02:26 +0100 From: Adrian Bunk To: Christoph Lameter Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ia64@ver.kernel.org, ak@suse.de Subject: Re: [RFC] Introduce atomic_long_t Message-ID: <20051209220226.GG23349@stusta.de> References: <20051209201127.GE23349@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 42 On Fri, Dec 09, 2005 at 01:57:05PM -0800, Christoph Lameter wrote: > On Fri, 9 Dec 2005, Adrian Bunk wrote: > > > What about creating an include/linux/atomic.h [1] that contains both > > this new code and other common code like the atomic_t typedef (unless > > there's a good reason why counter isn't volatile on h8300 and v850...). > > Ok that would look something like the attached patch [only exist to > give an idea on how this would work]. It would require > > 1. A replacement of all #include s with #include > throughout all files of the kernel > > 2. Rework of all include/asm-xx/atomic.h to extract common code. > > I will do just that if everyone agrees to this approach. >... I'd say the sequence is: 1. create an linux/atomic.h the #include's asm/atomic.h 2. convert all asm/atomic.h to use linux/atomic.h 3. move common code to linux/atomic.h There should be a small amount of time between 2. and 3. because doing all three steps at the same time in both Linus' tree and -mm sounds like a hard task. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/