Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7205947ybi; Thu, 1 Aug 2019 04:52:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQMSHrErrl2T7jG/bGwaGaFdRjiGHdYTyaQBVvN1jSgz92I2YqgUa1JElhl3snIfG/kKBV X-Received: by 2002:a63:194f:: with SMTP id 15mr84920762pgz.382.1564660330931; Thu, 01 Aug 2019 04:52:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564660330; cv=none; d=google.com; s=arc-20160816; b=nF0ook7nAlD+o3pVKdP2UXiNfFlCB/3l+AmhoxYL4ZYxQO0bf1tdPcD3l5ga0RP78a ZcTkaapZTQLvCCp3s+ml7vS6eYYv2h4MLC3zzgQCRNYWC27CPWd98ReL61OuWF6dVSLt gwOinAAPddj++zJFSvcDNkMT80nHAjF4Xiu1gE+vZUGWHMhlBcQig6vwaOodHvl/Lc5m BJguc+qL+l7F5SH4I6iU+n7qRZbGoIMqm4Jlp3G+wH8t3Yy32ilAGVRgU69TngKFS/2j cKqBmgU4sDFwzaYcD/2vj4AiiUNPcT1A1dQgAxUp2KsB2uPzw1Yvg8bgfS3Gc/f9ABUj ZYlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=wFga/SX2vuui9wsVZIQ2dAa/dxF/0E2Ph5JxPFU34lc=; b=kAc5WTb1gffs8flImXEE9sKUwpneFS5r8t9Yc/8eb5NM8MrPaUjNOlI5SZkuje57Ni ebZURpjfLRNu4D3daRquHrO/bMw2jL2SOYUWgqjsataVBZv9Fk1Niia7UZq9MFpAWyHT DuHfmhyG4CHAgx7nPaME2VKBNOW7tX3ZPmXWdDW8ctukPONXuIHwZzwvu56bOCOzQOVC EmK+CIOFpVr6c9OiFaFW+wUt/k155g+eDDNjMhjFOuA2zoxZb4Vph5/a0Hp/xTycWRVC zpjt9iV2v65ery57mJ8IRBGRq09lsgmeBVlaooe43yJbhdWDOJbXXsrKhoCyu2KSx3hN T2kA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si32312590pgt.20.2019.08.01.04.51.55; Thu, 01 Aug 2019 04:52:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730971AbfHALuy (ORCPT + 99 others); Thu, 1 Aug 2019 07:50:54 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:33953 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729316AbfHALuy (ORCPT ); Thu, 1 Aug 2019 07:50:54 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ht9bd-0002nU-0F; Thu, 01 Aug 2019 13:50:49 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ht9ba-0001a0-I5; Thu, 01 Aug 2019 13:50:46 +0200 Date: Thu, 1 Aug 2019 13:50:46 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Schrempf Frieder Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Jiri Slaby Subject: Re: [PATCH] serial: imx: Avoid probe failure in case of missing gpiolib Message-ID: <20190801115046.lf66umgfj2xk6eqv@pengutronix.de> References: <20190801081524.22577-1-frieder.schrempf@kontron.de> <20190801084827.m42ci3amo37hmesi@pengutronix.de> <0674d68b-99fa-3408-1dd1-22dc84144b43@kontron.de> <20190801095529.dm3pvgts6cy6mbiq@pengutronix.de> <0174be55-5e40-8cc7-82c7-54f9de46f711@kontron.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0174be55-5e40-8cc7-82c7-54f9de46f711@kontron.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Aug 01, 2019 at 10:59:54AM +0000, Schrempf Frieder wrote: > So I would rather go with a variation of your second proposal and keep > the dummy implementation, but let it return NULL instead of an error > pointer, as all the mctrl_gpio_*() functions already seem to have a > check for gpios == NULL. > > What do you think? I'll gladly review a patch. Best regads Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |