Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932495AbVLIWu2 (ORCPT ); Fri, 9 Dec 2005 17:50:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932496AbVLIWu2 (ORCPT ); Fri, 9 Dec 2005 17:50:28 -0500 Received: from ns.suse.de ([195.135.220.2]:34176 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S932495AbVLIWu1 (ORCPT ); Fri, 9 Dec 2005 17:50:27 -0500 Date: Fri, 9 Dec 2005 23:50:25 +0100 From: Andi Kleen To: Adrian Bunk Cc: Andi Kleen , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ia64@ver.kernel.org Subject: Re: [RFC] Introduce atomic_long_t Message-ID: <20051209225025.GM11190@wotan.suse.de> References: <20051209201127.GE23349@stusta.de> <20051209220226.GG23349@stusta.de> <20051209222045.GL11190@wotan.suse.de> <20051209223327.GH23349@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051209223327.GH23349@stusta.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 31 On Fri, Dec 09, 2005 at 11:33:28PM +0100, Adrian Bunk wrote: > On Fri, Dec 09, 2005 at 11:20:45PM +0100, Andi Kleen wrote: > > > I'd say the sequence is: > > > 1. create an linux/atomic.h the #include's asm/atomic.h > > > 2. convert all asm/atomic.h to use linux/atomic.h > > > 3. move common code to linux/atomic.h > > > > I don't think there is much common code actually. atomic_t > > details vary widly between architectures. Just defining > > a few macros to others is really not significant. I think > > Christoph's original patch was just fine. > > All of Christoph's original patch contains common code. > > The amount of duplication his patch would create alone would IMHO be > worth creating an linux/atomic.h. There wasn't actually much code in there. And defining asm-generic/atomic-long-on-32bit.h and asm-generic/atomic-long-on-64bit.h like you essentially proposed would just obfuscate the code, not make it easier to maintain. Aiming for common code is ok, but only when it actually improves maintainability. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/