Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964892AbVLIW6S (ORCPT ); Fri, 9 Dec 2005 17:58:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964893AbVLIW6R (ORCPT ); Fri, 9 Dec 2005 17:58:17 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:17421 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S964892AbVLIW6R (ORCPT ); Fri, 9 Dec 2005 17:58:17 -0500 Date: Fri, 9 Dec 2005 23:58:15 +0100 From: Adrian Bunk To: Andi Kleen Cc: Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ia64@ver.kernel.org Subject: Re: [RFC] Introduce atomic_long_t Message-ID: <20051209225814.GI23349@stusta.de> References: <20051209201127.GE23349@stusta.de> <20051209220226.GG23349@stusta.de> <20051209222045.GL11190@wotan.suse.de> <20051209223327.GH23349@stusta.de> <20051209225025.GM11190@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051209225025.GM11190@wotan.suse.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1702 Lines: 46 On Fri, Dec 09, 2005 at 11:50:25PM +0100, Andi Kleen wrote: > On Fri, Dec 09, 2005 at 11:33:28PM +0100, Adrian Bunk wrote: > > On Fri, Dec 09, 2005 at 11:20:45PM +0100, Andi Kleen wrote: > > > > I'd say the sequence is: > > > > 1. create an linux/atomic.h the #include's asm/atomic.h > > > > 2. convert all asm/atomic.h to use linux/atomic.h > > > > 3. move common code to linux/atomic.h > > > > > > I don't think there is much common code actually. atomic_t > > > details vary widly between architectures. Just defining > > > a few macros to others is really not significant. I think > > > Christoph's original patch was just fine. > > > > All of Christoph's original patch contains common code. > > > > The amount of duplication his patch would create alone would IMHO be > > worth creating an linux/atomic.h. > > There wasn't actually much code in there. And defining > asm-generic/atomic-long-on-32bit.h and asm-generic/atomic-long-on-64bit.h > like you essentially proposed would just obfuscate the code, not make it > easier to maintain. >... That's not what I proposed. The second revision of Christoph's patch implements in include/linux/atomic.h what I was thinking of. > -Andi cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/