Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7479372ybi; Thu, 1 Aug 2019 08:47:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyjTigpiALQT9Eu0g3Dmtjj9Bn01GcT5mY5yzS4Zh0ERrDSHz4Q82n6mNmkSIXW7cKbqi0T X-Received: by 2002:a63:3c5:: with SMTP id 188mr117430400pgd.394.1564674462874; Thu, 01 Aug 2019 08:47:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564674462; cv=none; d=google.com; s=arc-20160816; b=bayJ4JBpU9+EYkhBorXV1c/QUxyckUnYYbolVP8e2ghqIdJOfJGuV3ttlgaM+PGwVN YrQvguZIms+beqcb4WXK9VCUL6V1B6BdWLUvCsPM+UVpzx0z+0oObN4WoscZtCGCAbrT kiGUB0pI7GVGIJqF8aJOq5xfBM9bPO+uUQZlUnF6Nz1K++lrSbwTnYCOPjX9WCWQ3nNT uTIvynVNW2JFN1kN7pCmcdiySx55mORPWyw3Y25JHgFR9ReYHvNkxm0paTIToQjxp6aJ gofh+7xQ91iNZlVVOiglHiP+lFC4NwRpDz0mSUMO/JQ5IepqyLREshYSJjJyrQERzAzU O0uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=yOMIEOoJyU6PdmjsTxm7QjEJSeUYKSTKpb4tS2Mem4c=; b=ubVt/M7h/EiWfmxoZZigJUF7sEW25fIIh756aoeJtFJjqvPQffLNhn8xM4hPNOjv88 QjFyzuU4LO0jvMVLBIayqa90R0ILuwkd1tiLd7eBc2yq0z9bAfdVzZcD5+W4IoFeRlav +Z8prRXsR3j6AuIkCtUzVg9BRO/ZZooQDqDnMGfm1Dd+6m7roLkmC7+srG69djprmbER 6YOXkt7r9gHQC2LTfrGhnpFbGqGGTW3b29oHIQXipWeDWjkz0qw6hS9CVXA59MwKC19d UfkDsWBcVMn/i1EUOYfJmIYcw6TtR9pgZ7H6f8WPki2UMS6XgvLfbmEJSKWp+dwFfhgi ZhFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Sb577GZw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2si8190321pfg.136.2019.08.01.08.47.27; Thu, 01 Aug 2019 08:47:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Sb577GZw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731171AbfHAPA6 (ORCPT + 99 others); Thu, 1 Aug 2019 11:00:58 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:46515 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbfHAPA6 (ORCPT ); Thu, 1 Aug 2019 11:00:58 -0400 Received: by mail-pl1-f196.google.com with SMTP id c2so32311854plz.13; Thu, 01 Aug 2019 08:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yOMIEOoJyU6PdmjsTxm7QjEJSeUYKSTKpb4tS2Mem4c=; b=Sb577GZwApsFb/zlrgWCzg0pTJqWahM59fxPtzybeJ58RPsL6p/WBRZBD0Z/dPAsH3 NVpTF3QtKIVT/YoLyK109iP3uzjRKS0WAuLWzFPp52V46RpiQtfYNiKfCb+t0wMWlxZr 5d8ydOMogInnafOtLivwqixh/93o/sfNAw13rrbKx4d7YBL7PJD2kZl1BskWuaAwIhvo U3zC1Pvn5ECODn5vTtZnEdOw2rKo6XA0m3j/S+apPT5qey/VJJL8j0r5ikP3ZVuxXv2T U1bFXNOeGsnmfIgKbysepi8RuwV94zefKG9QY4arNg7dIxdHLTB3Hztq13VyEPxcQH8K iYeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yOMIEOoJyU6PdmjsTxm7QjEJSeUYKSTKpb4tS2Mem4c=; b=cLXJr4s0ndhvSlHl5E/ncP1IQrhghRjDOqUAOYGH5hYr1acUR6jPsH7VFj8rlvQIQO ux/RCj4pKHgOd3U80Za+zZ9Cw8bp4N89ozvCIGcEDEV5MHAM8m8d9c8nmHas5WgINbkD te6bYrd1B49jYz9wn1QTd9ZjDX495jFmumswyhzlrlML9NfRcCkP/ak55ONWUXuKEbba 8f80qtzpABobZFR81BQdf9bmGugfsBMQirn4pawafN+QbihkAp5f1zzu5cCH1yuTBbD7 2PZkvArSJ/VbEWG1RNevhiM0jZvexbbw/LSH3eFZ1JKzSX/Th4vOzgofvAwxyq624jlo VT+Q== X-Gm-Message-State: APjAAAUQXj4wPcin6akijzUeHhlarxpMqXaYAUXvDM84ZmLR2tynXNE1 n6xevC2lWd9YQ4p255APNAkabwfm0eyx2EgwmDY= X-Received: by 2002:a17:902:694a:: with SMTP id k10mr125267948plt.255.1564671657662; Thu, 01 Aug 2019 08:00:57 -0700 (PDT) MIME-Version: 1.0 References: <1564081563-28322-1-git-send-email-info@metux.net> In-Reply-To: <1564081563-28322-1-git-send-email-info@metux.net> From: Andy Shevchenko Date: Thu, 1 Aug 2019 18:00:46 +0300 Message-ID: Subject: Re: [PATCH v2] platform/x86/pcengines-apuv2: use KEY_RESTART for front button To: "Enrico Weigelt, metux IT consult" Cc: Linux Kernel Mailing List , Darren Hart , Andy Shevchenko , Platform Driver Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2019 at 10:06 PM Enrico Weigelt, metux IT consult wrote: > > From: Enrico Weigelt > > The keycode KEY_RESTART is more appropriate for the front button, > as most people use it for things like restart or factory reset. > Applied, thanks! > Signed-off-by: Enrico Weigelt > Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe ("x86: pcengines apuv2 gpio/leds/keys platform driver") Please, use allowed minimum (12 nowadays) characters of hash. > --- > drivers/platform/x86/pcengines-apuv2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c > index b0d3110..4138007c 100644 > --- a/drivers/platform/x86/pcengines-apuv2.c > +++ b/drivers/platform/x86/pcengines-apuv2.c > @@ -93,7 +93,7 @@ > > static struct gpio_keys_button apu2_keys_buttons[] = { > { > - .code = KEY_SETUP, > + .code = KEY_RESTART, > .active_low = 1, > .desc = "front button", > .type = EV_KEY, > -- > 1.9.1 > -- With Best Regards, Andy Shevchenko