Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932498AbVLIXZg (ORCPT ); Fri, 9 Dec 2005 18:25:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932513AbVLIXZg (ORCPT ); Fri, 9 Dec 2005 18:25:36 -0500 Received: from smtp.osdl.org ([65.172.181.4]:21421 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932498AbVLIXZf (ORCPT ); Fri, 9 Dec 2005 18:25:35 -0500 Date: Fri, 9 Dec 2005 15:26:25 -0800 From: Andrew Morton To: Ben Gardner Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] i386: CS5535 chip support - GPIO Message-Id: <20051209152625.130641bb.akpm@osdl.org> In-Reply-To: <808c8e9d0512070933re472072x43f35d454be699f1@mail.gmail.com> References: <808c8e9d0512070933re472072x43f35d454be699f1@mail.gmail.com> X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 547 Lines: 15 Ben Gardner wrote: > > +/* These are defined in cs5535.c */ > +extern u32 cs5535_gpio_base; > +extern u32 cs5535_gpio_mask; And they should be declared in a header file, please. Is there a reason for these being exported to non-GPL modules, or can they be EXPORT_SYMBOL_GPL()? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/