Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7481199ybi; Thu, 1 Aug 2019 08:49:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqzvImsT0DZBqlAcQiXebu2mpwvHnHTuYRfYl+vFJ6llsG4hB7Q66RaEXkKJWIuDXX/FE3It X-Received: by 2002:a63:dc4f:: with SMTP id f15mr7410323pgj.227.1564674562015; Thu, 01 Aug 2019 08:49:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564674562; cv=none; d=google.com; s=arc-20160816; b=Hhhj/HwuNFG9yy5/YfONUxBb3Z5V7X4VYzU7+YL2mrAnMssHkRE+HopqItlssEecBD cqBCHbNwuLfcitOLR2zYU8a1yMC+xdVCzAMmM6NAUYRgu2BbiEyVExWm5Vlu8RUyj+TJ GEE4iVEw1sKKG/zkeIr/dCr5iKBckVY99bckeCmXlf7oLnnDYhpY5WpVW2H//URa9uHI CGxGhyGgFVx1abB5afpsR8WBloTIolLPhQ6WS2xdKqrHCtP57t45lqw16Uc2xpatLXCJ zIDVObqe6cPb7TUL9TIHOaGg96/jBYtqy2wJ0Vm9lXsRUGntkY9uhkCKDptN9TqEXnGT QPLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=gIfSabpVp9eE7lJHzBppB62vKhN84Wb7zIuuCObxbsE=; b=LCuat+exA0DSfhgc2PQ2oyNwwc9/pcRMF32pVKaZhxgK6DiIVQOP5VkoznaCFWTCcb DUb6IC8VgfE8ztO3yBBVDInCIAccKt7dVslYFuutWLHxNdcrdxWdAEY010SR6QjXSroO jqmpPIFlsxh4d2Ny+URkY2WVYKcbNdP64uAzM6q54vgBdEDEtWKIhQkhNSluoXik0MbH 29D+iBu8Fw5s3gF5Ft5popqbBn80OpPVy0vdTC/E9SaKUitt5ltXXB6B/Uz3+TtTyYgh CAywZciBG3mVKiQV0VgMJuiHxrLPMiT+5cWcrsx8l1Bwy2YQvEMQX4gIZI92pfH2deYy j5pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ZNrTD/eg"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si32625733plz.101.2019.08.01.08.49.06; Thu, 01 Aug 2019 08:49:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ZNrTD/eg"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732452AbfHAPS7 (ORCPT + 99 others); Thu, 1 Aug 2019 11:18:59 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:40182 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730835AbfHAPS6 (ORCPT ); Thu, 1 Aug 2019 11:18:58 -0400 Received: by mail-ed1-f66.google.com with SMTP id k8so69503310eds.7 for ; Thu, 01 Aug 2019 08:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gIfSabpVp9eE7lJHzBppB62vKhN84Wb7zIuuCObxbsE=; b=ZNrTD/egNWyggNQI4aKhw3rt484V0kvyB4GuTDajjJPMP/vSaPJ0VuKljCqlbb+P5A hiRrdAK2QJlU7pZ92i3/6LTZgDwgXzRHGJeelw/vI2reaGscjHx1CxZiBhfL960X6Ml+ TfZdbaazxJGcfI2xZ1kF0Z1/sVrMw6Sq9ea+zlCmGiovy2qkcz0EUWurWeapH8GvMTni 12OJLt1vEQYnJKMakup4T/6eArPfE72r6UQ4h9n3BY/xPpxWimbCg7s6E108ASiiW1qI eVS9DIQBAFDZmVUk4nZDVsgHA/Z3b12+wE+0CJbESVN03dDSpW8pM3e7reqOp1fVXXnj Obbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gIfSabpVp9eE7lJHzBppB62vKhN84Wb7zIuuCObxbsE=; b=hh0Z19e1R34z1MLK/Bk1fN3YF2XLxpNja0052H3tXMbeX9wZcmJV803VeVWEQvir6N fqO3dbfPNwh7cToSBEMMXgh34fnveuLzIVIPVJjZDMpaXVvdlWMqoUTqX4coPecSOhp6 Zl40vI/9XUqZEfPWXsfmen3f3RfFH/AbDtcLc9ctORuOpInSketAj2Px84ylBUs9nTO4 y34qcwm9ldvCJ9PSZQkJYSR8VXJjMsuhBC3JSrVeXvKu/LuSb2aeIhAvtXlTT2wtKCzj 00IOCjZdVzmJrmg3p36LJTlMS/7yFACo0DXbOfcmZKe3RMtqOhGH7mcPvq10PSJ2bzVp ZUZA== X-Gm-Message-State: APjAAAWq7+28w7kEFFpKSZFTzrSXDAS3VKrfsJ586bIvrqMyA1PmMMXv 7ZeV3hBlheS1uDLLASkbieMh3fnAKTsuoflOleg= X-Received: by 2002:a17:906:3612:: with SMTP id q18mr102805422ejb.278.1564672736964; Thu, 01 Aug 2019 08:18:56 -0700 (PDT) MIME-Version: 1.0 References: <20190717211542.30482-1-robdclark@gmail.com> <20190719092153.GJ15868@phenom.ffwll.local> <20190731192331.GT104440@art_vandelay> <156466322613.6045.7313079853087889718@skylake-alporthouse-com> In-Reply-To: <156466322613.6045.7313079853087889718@skylake-alporthouse-com> From: Rob Clark Date: Thu, 1 Aug 2019 08:18:45 -0700 Message-ID: Subject: Re: [PATCH] drm/vgem: fix cache synchronization on arm/arm64 To: Chris Wilson Cc: David Airlie , Deepak Sharma , Emil Velikov , Eric Anholt , Eric Biggers , Imre Deak , Rob Clark , Sean Paul , Thomas Zimmermann , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 1, 2019 at 5:40 AM Chris Wilson wrote: > > Quoting Sean Paul (2019-07-31 20:23:31) > > On Fri, Jul 19, 2019 at 11:21:53AM +0200, Daniel Vetter wrote: > > > On Wed, Jul 17, 2019 at 02:15:37PM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > drm_cflush_pages() is no-op on arm/arm64. But instead we can use > > > > dma_sync API. > > > > > > > > Fixes failures w/ vgem_test. > > > > > > > > Signed-off-by: Rob Clark > > > > --- > > > > An alternative approach to the series[1] I sent yesterday > > > > > > > > On the plus side, it keeps the WC buffers and avoids any drm core > > > > changes. On the minus side, I don't think it will work (at least > > > > on arm64) prior to v5.0[2], so the fix can't be backported very > > > > far. > > > > > > Yeah seems a lot more reasonable. > > > > > > Acked-by: Daniel Vetter > > > > Applied to drm-misc-fixes, thanks! > > But it didn't actually fix the failures in CI. Hmm, that is unfortunate, I'd assumed that silence meant latest version was working in CI.. dma_sync_sg_* doesn't work on x86? It would be kinda unfortunate to have vgem only work on x86 *or* arm.. maybe bringing back drm_cflush_pages() could make it work in both cases BR, -R