Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7675875ybi; Thu, 1 Aug 2019 11:56:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqys88/67VK4SEEkmmcE8BEtWCpyReb0e2lCCk3Tx3rKcZnCuNhw1UOGXYGEphb2o9M+49Yb X-Received: by 2002:a63:3147:: with SMTP id x68mr57728945pgx.212.1564685772943; Thu, 01 Aug 2019 11:56:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564685772; cv=none; d=google.com; s=arc-20160816; b=tI7e9V87V1xemg9E00NybwgAjAEYHEMNzs/A+GjOUydYYCer/VvHshJb/RqvEJPZPy 8vgnH0w9y8aNidWhUtvfwe47IT7Hw8PX6aJbm5nXyrEG9RsNTQO0Blum0sm0FGduOwMd Cgnasq9JoPImLG6oB8d0mIqa52eIOmjLRYy3G/zWE+aH1+LvBL3p7iBoOAatqg9+VS6w BPPrtG85Nc6uAG+CGemGgzRLme+ty0RnepdUzhdzhNQFS/5Ohm9yumCqZryqSnXkm456 cyLsvvoFKvG7YubhYaSYbvYLZAyfkGlSm7WrnupreNQFZ6tqFPnBUj3tyns62dOK8KHM bdWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=u9qbqYynIxIkl29A6TupUnFsBpht9AHM96ELeORQMiI=; b=qnZk2KfdAZt9E+i7l6SBNZAlD554LXkQ5FRGj3MAIh3zUBbKsg/OlMKpsnz58dwdtq SkqM0/+uG6VGBOg/0ws/fP6+j+R4QMIXbVbUU5SZPlSAgKhnLePhkvFHrRt5SjRLlUit eLrY7IKXdqevnTH+5UH2u1WCfqIF4es9Ny6VgQy+cKBpjYO8kwNUYjAfCeK67bsZ5sTN dYhzj5my7o3gUlIMIVCINanQDTXjGPFemPkcg0KtdqmqupUFTBXHNuFf7i9aJ+o8L7MI fcdJQBaihtOaEXKh44t5HHHWXtPmf+Yu8nSSm1yFAkeGCO9rt+LXVYYBatcU9+IFB1Hq XOsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ci19si33085161plb.165.2019.08.01.11.55.56; Thu, 01 Aug 2019 11:56:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733084AbfHASp3 convert rfc822-to-8bit (ORCPT + 99 others); Thu, 1 Aug 2019 14:45:29 -0400 Received: from skedge04.snt-world.com ([91.208.41.69]:44592 "EHLO skedge04.snt-world.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbfHASp1 (ORCPT ); Thu, 1 Aug 2019 14:45:27 -0400 Received: from sntmail10s.snt-is.com (unknown [10.203.32.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge04.snt-world.com (Postfix) with ESMTPS id 84B6467A88B; Thu, 1 Aug 2019 20:45:25 +0200 (CEST) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail10s.snt-is.com (10.203.32.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 1 Aug 2019 20:45:25 +0200 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1713.004; Thu, 1 Aug 2019 20:45:25 +0200 From: Schrempf Frieder To: "u.kleine-koenig@pengutronix.de" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-imx@nxp.com" , Greg Kroah-Hartman CC: "linux-arm-kernel@lists.infradead.org" , "geert+renesas@glider.be" , Schrempf Frieder , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH v2 2/3] serial: sh-sci: Remove check for specific mctrl_gpio_init() return value Thread-Topic: [PATCH v2 2/3] serial: sh-sci: Remove check for specific mctrl_gpio_init() return value Thread-Index: AQHVSJlHEoc0h/HtdUeNtLGwgfHXXA== Date: Thu, 1 Aug 2019 18:45:24 +0000 Message-ID: <20190801184505.17239-2-frieder.schrempf@kontron.de> References: <20190801184505.17239-1-frieder.schrempf@kontron.de> In-Reply-To: <20190801184505.17239-1-frieder.schrempf@kontron.de> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.17.1 x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: 84B6467A88B.AF016 X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: festevam@gmail.com, geert+renesas@glider.be, gregkh@linuxfoundation.org, jslaby@suse.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, u.kleine-koenig@pengutronix.de X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frieder Schrempf Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS) in cases when CONFIG_GPIOLIB is disabled, we can safely remove this check. Signed-off-by: Frieder Schrempf --- drivers/tty/serial/sh-sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index d18c680aa64b..249325b65ee0 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -3287,7 +3287,7 @@ static int sci_probe_single(struct platform_device *dev, return ret; sciport->gpios = mctrl_gpio_init(&sciport->port, 0); - if (IS_ERR(sciport->gpios) && PTR_ERR(sciport->gpios) != -ENOSYS) + if (IS_ERR(sciport->gpios)) return PTR_ERR(sciport->gpios); if (sciport->has_rtscts) { -- 2.17.1