Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11687ybi; Thu, 1 Aug 2019 13:40:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYYqw3qUPZsj6aMKhTTMJoyv0vvXVr6Qp7A6xVslISIhPiYgBG4d5kWmogpdrXAUpOBZBA X-Received: by 2002:a65:4205:: with SMTP id c5mr9469482pgq.267.1564692018531; Thu, 01 Aug 2019 13:40:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564692018; cv=none; d=google.com; s=arc-20160816; b=gNO7ZXVh9bwuu4Dk5MtVe8GrjxtB/X3B9F4KVP7bE/OOl7yEXt8u2tgeHxdz03EZbY AHoVHrDTDGYbCZBlGyhdeiCJ0S6tDZm2TBzxRHs5hLL97MiCKUXrzazkhkIT3L7D1YqX qlysE9N3KfH7NcAVtpAHPtiMEuIxvuvwX4hHFLY4EibfZCOErPXRevcLAorYvu2EgVeD quwgYgbI11vfAY1jEdx6CjbY58c8fyGNWQ59IlA8+Nc0CzQQjLaBbMmptFzl4PdYWwoZ eD8bRt60Pgg6VzPLg0rWa8RHqqcZiRDgX8y35X6odJjyJP0T84wZ7YJ6Tke9ERp1IpNn rmpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=mUp8/SSf5/EUu564B+4etNjxrngQkR0bNmXFEwjW9Tw=; b=Qq8Hoj+b5UPgPovd7rwmI/f30JwvNctd+Hy7R7yOiiFk9CFHHXxEHWJdKk86uAZII3 eJl+BXjZ2SzHIldHxgWTjvNvhcTqmXJsoNBu8iuLuq+T0EfTZsKDcYkjsMArCaB8C3Zm AT3zf4WCWWGjOxBmCAPQcNcoA6WTDKWh9AB0dSzIvshKcgxKdE3R9yGUhXZ+BjMt04cJ WhfjnW2sp9kJzcgypErAlXWEPGkQaZkNY2HKa29ZBsyEO6LPcuSSTo++bMdM1cCBkn7x e89imJ+9teYtDUwGPdoGHyJjvUOZPaSHILJq8jTUq+caL0OdM6KPzeuqGVE2qVkpL8DZ manA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i10si39259704pfr.130.2019.08.01.13.40.02; Thu, 01 Aug 2019 13:40:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730457AbfHAUjH (ORCPT + 99 others); Thu, 1 Aug 2019 16:39:07 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:40799 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728714AbfHAUjH (ORCPT ); Thu, 1 Aug 2019 16:39:07 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1htHqp-0003ty-I9; Thu, 01 Aug 2019 22:39:03 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1htHqo-0001xt-8C; Thu, 01 Aug 2019 22:39:02 +0200 Date: Thu, 1 Aug 2019 22:39:02 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Schrempf Frieder Cc: "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-imx@nxp.com" , Greg Kroah-Hartman , "geert+renesas@glider.be" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Jiri Slaby , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 2/3] serial: sh-sci: Remove check for specific mctrl_gpio_init() return value Message-ID: <20190801203902.xie5dexnsoqxxlat@pengutronix.de> References: <20190801184505.17239-1-frieder.schrempf@kontron.de> <20190801184505.17239-2-frieder.schrempf@kontron.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190801184505.17239-2-frieder.schrempf@kontron.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 01, 2019 at 06:45:24PM +0000, Schrempf Frieder wrote: > From: Frieder Schrempf > > Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS) > in cases when CONFIG_GPIOLIB is disabled, we can safely remove this > check. I would mention -ENOSYS in the Subject line. Something like: serial: sh-sci: don't check for mctrl_gpio_init returning -ENOSYS Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS) if CONFIG_GPIOLIB is disabled, we can safely remove this check. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |