Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp15970ybi;
        Thu, 1 Aug 2019 13:45:38 -0700 (PDT)
X-Google-Smtp-Source: APXvYqy8hoEHaueXQL/BNoQU2W7+AacODxatuXek3rPJE7YXQgkNIr8X0/0nGRbUf7QUMVwnDlHB
X-Received: by 2002:aa7:940c:: with SMTP id x12mr56477689pfo.80.1564692338081;
        Thu, 01 Aug 2019 13:45:38 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1564692338; cv=none;
        d=google.com; s=arc-20160816;
        b=ryj5dN3H9cDIsWnewFciFqdz01Wh/hmnKJKjpY6oSp8VBIxdN1Fx9dzDGm+faAkReq
         ILrstlWgKY4F+eBwp2dZ0PQ2a04Y5mRenjUZq9bei5F0kWCKzoQdwVPUyKtiapY83rfC
         594x1S5HVwrfm5GuFbH+6IA7lkgvfLGIHwAC0y04R90v/WqTBz9bsemaXJQMlzlBzPSo
         S3ZLLtiQrPrN82vBxOzlDjzfB8dZ36NtzSK4ICBrZJZMBenCWiVblLXaxxC3DbmPsrSI
         kjRvquxwdpQJLTrZkHty6VmhQAw0cIfy3PGEW8O06aOZYxTRsW39VjuSmo2DEMrSi1e3
         UttQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=kEYB2+OVQo5XUoP0DBjTnNKzZvTb5NJlv5p6H9Nyzv4=;
        b=Tb7H24KWvUBFWaiwvn1Rmfkjpz01VIlVePFLG1uEQJyb1mpDgCczFmTpkx47/3fXao
         5X5wNePEljnQqCNUPB+Lu2geeJXeATNqt7R4B3mjL7V9sdbhhvC3Jq0nZy6iWoYveRIy
         bq+t4uePvUFrquKra10uHgEnoU53vdQ3NHTbNcnHMv6mLyUq4q4C3TsaGhHHee0AAM+D
         S5oGKhBrmBm7r/ImzpSWZnZEQgXcv467DJQLcqSSI/chV/mCpU7ZTF3cOjyVV5xhlwJS
         yRaVGp9mncPxtcCi4SwuR979QfsZm4z92Mcbwyd7qMzS7upozX07nWqa1Dui3trWcdfn
         k5mA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@google.com header.s=20161025 header.b="p9nP+P/1";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id y8si38074132pgk.594.2019.08.01.13.45.22;
        Thu, 01 Aug 2019 13:45:38 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@google.com header.s=20161025 header.b="p9nP+P/1";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2387470AbfHAUoX (ORCPT <rfc822;patchstalker@gmail.com>
        + 99 others); Thu, 1 Aug 2019 16:44:23 -0400
Received: from mail-io1-f65.google.com ([209.85.166.65]:36540 "EHLO
        mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728904AbfHAUoW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Aug 2019 16:44:22 -0400
Received: by mail-io1-f65.google.com with SMTP id o9so43775396iom.3
        for <linux-kernel@vger.kernel.org>; Thu, 01 Aug 2019 13:44:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=kEYB2+OVQo5XUoP0DBjTnNKzZvTb5NJlv5p6H9Nyzv4=;
        b=p9nP+P/1loHtaBCdy0RixW63mz45R3rvCZ00Zldzay+dbiKdcAlP60JiUO+vB9DPGE
         NQJ1C+W5QRgA7GRQUTDum4dZCx4LwgnvuxVsXej6GZylA+kvpVZq6l0dgut7812mYn35
         DsWqOMKrGeUGD4tPXmYcmWJx8fuBLkIxm3KMTmysQD92yPn1C5Vm+b1mi3yzYNgbfw2/
         Y8DRxS8fqk8/SDEMiHv8A4b1GCoQG4Xo4d3w8Q7d89vyRaK4T2aOw/ElbTU7zkWGpfdv
         PY4K3r3n6JTqdYh5mfC26n9HDI5B+8uPadncMj+1BwM8CqiGALvnDTb7ncp/F7ZNkpCx
         tO1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=kEYB2+OVQo5XUoP0DBjTnNKzZvTb5NJlv5p6H9Nyzv4=;
        b=UzTjR0x7LJkG1vlgzQ0a8lH8kEANaod5gcqxatRFdugaQfKKXlI1sP0zqegso4bhQG
         /J7O1VXZBTKsT2YS2bP6F2oGulOVGi1KT2C2QFqfx8kQ/iDCFVQvOscXtwI76a4e43lc
         vDt0dTM31rg0Oi99S77WB4XuhFyySECaMNLqiV85bHUzVctk2h5mk9W/AZA/4ZXpQVw9
         tI3Zb0gQ7xaZ6y+TVHN+Iyy+F0Ziau/zLUhOcvxc7wKnmwCAy1mo+VjrlKvT+OuMSm0l
         C3A+liQmisz6xlsey6Iv4UtSK25OuSiokQdWomS1tItIKmVFcVmaxKQ5D4Ofk+cOoUEE
         TPCA==
X-Gm-Message-State: APjAAAVCdSDTRvChIYr2puM85vXEAHRjX7sZ1ZsGUpPTYJJ50uHdxHK/
        6AKDYTR0v7eNDb0OMW1qR3qL0c5ooh4ZRa5GFTH46A==
X-Received: by 2002:a5d:97d8:: with SMTP id k24mr5004672ios.84.1564692261567;
 Thu, 01 Aug 2019 13:44:21 -0700 (PDT)
MIME-Version: 1.0
References: <20190731221617.234725-1-matthewgarrett@google.com>
 <20190731221617.234725-20-matthewgarrett@google.com> <20190801161933.GB5834@linux-8ccs>
In-Reply-To: <20190801161933.GB5834@linux-8ccs>
From:   Matthew Garrett <mjg59@google.com>
Date:   Thu, 1 Aug 2019 13:44:10 -0700
Message-ID: <CACdnJutXUO9e0ti8tHtJ8z3xX6dcn4Cczbs-wMBRr07BM3iCvQ@mail.gmail.com>
Subject: Re: [PATCH V37 19/29] Lock down module params that specify hardware
 parameters (eg. ioport)
To:     Jessica Yu <jeyu@kernel.org>
Cc:     James Morris <jmorris@namei.org>,
        LSM List <linux-security-module@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux API <linux-api@vger.kernel.org>,
        David Howells <dhowells@redhat.com>,
        Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 1, 2019 at 9:19 AM Jessica Yu <jeyu@kernel.org> wrote:

> Hm, I don't think the doing parameter ended up being used in this function?

Thanks for catching that, I'll fix.