Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1564686979.11067.48.camel@lca.pw>
Subject: Re: [PATCH v2] acpica: fix -Wnull-pointer-arithmetic warnings
From:   Qian Cai <cai@lca.pw>
To:     "Moore, Robert" <robert.moore@intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
Cc:     "Schmauss, Erik" <erik.schmauss@intel.com>,
        "jkim@FreeBSD.org" <jkim@FreeBSD.org>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "ndesaulniers@google.com" <ndesaulniers@google.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "clang-built-linux@googlegroups.com" 
        <clang-built-linux@googlegroups.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Thu, 01 Aug 2019 15:16:19 -0400
In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E3B9661CBD@ORSMSX110.amr.corp.intel.com>
References: <20190718194846.1880-1-cai@lca.pw>
         <94F2FBAB4432B54E8AACC7DFDE6C92E3B9661CBD@ORSMSX110.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-07-26 at 19:35 +0000, Moore, Robert wrote:
> We've taken the change to ACPI_TO_POINTER.

I am a bit confused here. I saw the commit in the acpia repo.

https://github.com/acpica/acpica/commit/02bbca5070e42d298c9b824300aa0eb8a082d797

but how does that change will go into the linux kernel? Suppose Rafael will need
to pick it up manually?

> 
> 
> -----Original Message-----
> From: Qian Cai [mailto:cai@lca.pw] 
> Sent: Thursday, July 18, 2019 12:49 PM
> To: Wysocki, Rafael J <rafael.j.wysocki@intel.com>
> Cc: Moore, Robert <robert.moore@intel.com>; Schmauss, Erik <erik.schmauss@inte
> l.com>; jkim@FreeBSD.org; lenb@kernel.org; ndesaulniers@google.com; linux-acpi
> @vger.kernel.org; devel@acpica.org; clang-built-linux@googlegroups.com; linux-
> kernel@vger.kernel.org; Qian Cai <cai@lca.pw>
> Subject: [PATCH v2] acpica: fix -Wnull-pointer-arithmetic warnings
> 
> Clang generate quite a few of those warnings.
> 
> drivers/acpi/scan.c:759:28: warning: arithmetic on a null pointer treated as a
> cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
> 		status = acpi_get_handle(ACPI_ROOT_OBJECT,
> obj->string.pointer,
>                                          ^~~~~~~~~~~~~~~~
> ./include/acpi/actypes.h:458:56: note: expanded from macro 'ACPI_ROOT_OBJECT'
>  #define ACPI_ROOT_OBJECT                ((acpi_handle) ACPI_TO_POINTER
> (ACPI_MAX_PTR))
> 							^~~~~~~~~~~~~~~
> ./include/acpi/actypes.h:509:41: note: expanded from macro 'ACPI_TO_POINTER'
>  #define ACPI_TO_POINTER(i)              ACPI_ADD_PTR (void, (void *) 0,
> (acpi_size) (i))
>                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./include/acpi/actypes.h:503:84: note: expanded from macro 'ACPI_ADD_PTR'
>  #define ACPI_ADD_PTR(t, a, b)           ACPI_CAST_PTR (t,
> (ACPI_CAST_PTR (u8, (a)) + (acpi_size)(b)))
>                                          ^~~~~~~~~~~~~~~~~
> ./include/acpi/actypes.h:501:66: note: expanded from macro 'ACPI_CAST_PTR'
>  #define ACPI_CAST_PTR(t, p)             ((t *) (acpi_uintptr_t) (p))
>                                                                  ^ This is
> because pointer arithmetic on a pointer not pointing to an array is an
> undefined behavior (C11 6.5.6, constraint 8). Fix it by just casting the
> corresponding pointers using ACPI_CAST_PTR() and skip the arithmetic. Also,
> fix a checkpatch warning together.
> 
> ERROR: Macros with complex values should be enclosed in parentheses
>  #45: FILE: include/acpi/actypes.h:509:
> +#define ACPI_TO_POINTER(i)              ACPI_CAST_PTR (void, i)
> 
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> 
> v2: Use ACPI_CAST_PTR() in ACPI_TO_POINTER() directly without
>     arithmetic.
> 
>  include/acpi/actypes.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h index
> ad6892a24015..163181e2d884 100644
> --- a/include/acpi/actypes.h
> +++ b/include/acpi/actypes.h
> @@ -506,7 +506,7 @@ typedef u64 acpi_integer;
>  
>  /* Pointer/Integer type conversions */
>  
> -#define ACPI_TO_POINTER(i)              ACPI_ADD_PTR (void, (void *) 0,
> (acpi_size) (i))
> +#define ACPI_TO_POINTER(i)              (ACPI_CAST_PTR (void, i))
>  #define ACPI_TO_INTEGER(p)              ACPI_PTR_DIFF (p, (void *) 0)
>  #define ACPI_OFFSET(d, f)               ACPI_PTR_DIFF (&(((d *) 0)->f), (void
> *) 0)
>  #define ACPI_PHYSADDR_TO_PTR(i)         ACPI_TO_POINTER(i)
> --
> 2.20.1 (Apple Git-117)
>