Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1564630214-28442-1-git-send-email-wanpengli@tencent.com> <20190801133133.955E4216C8@mail.kernel.org>
In-Reply-To: <20190801133133.955E4216C8@mail.kernel.org>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Fri, 2 Aug 2019 08:46:11 +0800
Message-ID: <CANRm+Cy1wWSwn7HH-dNWeR6FX1TT_M7t_9vvRMdCKFATmvFDkA@mail.gmail.com>
Subject: Re: [PATCH v3 1/3] KVM: Fix leak vCPU's VMCS value into other pCPU
To:     Sasha Levin <sashal@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc:     Wanpeng Li <wanpengli@tencent.com>,
        LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Marc Zyngier <Marc.Zyngier@arm.com>,
        "# v3 . 10+" <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 1 Aug 2019 at 21:31, Sasha Levin <sashal@kernel.org> wrote:
>
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 98f4a1467612 KVM: add kvm_arch_vcpu_runnable() test to kvm=
_vcpu_on_spin() loop.
>
> The bot has tested the following trees: v5.2.4, v5.1.21, v4.19.62, v4.14.=
134, v4.9.186, v4.4.186.
>
> v5.2.4: Build failed! Errors:
>     arch/arm64/kvm/../../../virt/kvm/kvm_main.c:2483:31: error: =E2=80=98=
struct kvm_vcpu=E2=80=99 has no member named =E2=80=98async_pf=E2=80=99
>
> v5.1.21: Build failed! Errors:
>     arch/arm64/kvm/../../../virt/kvm/kvm_main.c:2415:31: error: =E2=80=98=
struct kvm_vcpu=E2=80=99 has no member named =E2=80=98async_pf=E2=80=99

Thanks for reporting this, after more grep, it seems that just x86 and
s390 enable async_pf in their Makefile. So I can move 'if
(!list_empty_careful(&vcpu->async_pf.done))' checking to
kvm_arch_dy_runnable(), Paolo, do you have more comments to v3 before
I send a new version?

Regards,
Wanpeng Li