Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190801111348.530242235@infradead.org> <20190801111541.685367413@infradead.org>
 <20190801174907.GA16554@cmpxchg.org> <CAJuCfpGQsfQ8QW7_LJzsGgTj6H9r6bV529Mzv-dXCWiv+qjOpw@mail.gmail.com>
In-Reply-To: <CAJuCfpGQsfQ8QW7_LJzsGgTj6H9r6bV529Mzv-dXCWiv+qjOpw@mail.gmail.com>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Thu, 1 Aug 2019 14:03:18 -0700
Message-ID: <CAJuCfpHT9HVLfE8zgm6ZgBpX7ZsVOZeAkoyHO+koD0SYih3yfg@mail.gmail.com>
Subject: Re: [PATCH 1/5] sched/pci: Reduce psimon FIFO priority
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     Peter Zijlstra <peterz@infradead.org>, mingo@kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 1, 2019 at 11:31 AM Suren Baghdasaryan <surenb@google.com> wrote:
>
> On Thu, Aug 1, 2019 at 10:49 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
> >
> > On Thu, Aug 01, 2019 at 01:13:49PM +0200, Peter Zijlstra wrote:
> > > PSI defaults to a FIFO-99 thread, reduce this to FIFO-1.

nit: above "PSI defaults" is more accurately "PSI polling defaults".
The core PSI thread that handles regular updates is a regular kthread.

> > >
> > > FIFO-99 is the very highest priority available to SCHED_FIFO and
> > > it not a suitable default; it would indicate the psi work is the
> > > most important work on the machine.
> > >
> > > Since Real-Time tasks will have pre-allocated memory and locked it in
> > > place, Real-Time tasks do not care about PSI. All it needs is to be
> > > above OTHER.
> > >
> > > Cc: Suren Baghdasaryan <surenb@google.com>
> > > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >
> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> >
> > Subject should be s/pci/psi/
>
> Thanks for the patch. Please give me a couple hours for testing to
> ensure no regressions before merging it.

Tested-by: Suren Baghdasaryan <surenb@google.com>