Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp427547ybi; Thu, 1 Aug 2019 21:58:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxLsFCb2lGtkTKEITBMo8MovZqYmisUM9+XTEE5DZsJiHkDcd+oLmHiVwM9ZvSw9t9N22sn X-Received: by 2002:a63:394:: with SMTP id 142mr4058335pgd.43.1564721903446; Thu, 01 Aug 2019 21:58:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564721903; cv=none; d=google.com; s=arc-20160816; b=yLO6sgzPMhD7dDc1ZH/Wz/jk/5EGzRmkiqg1He/KNPX5SIJMeQzYfm6mQ6Dbr8dadL oOKJUD8zLbNgXYYNs3BZnKT1JfH8zzC5ViXxXdkmIaQHh032aw4/1jlQMK3HdCnn+edE UpiBHZIHLAoN/p0xWfdhUtiX1k3ZuqHTJo3SrHAgXOcWejRg4seta7NtJ3214+UxkFts SYAuXF1BlpxGGoXIEoU9WIWEtoq/VJHbtecejJOK7KYAN277QPXcvG7o7mbWY7kMJyQD WqbZjyRGacaLyWCoU1l9aopPsW9irMII7nryPdgHNqiq+uYdsb1bAgAv1kzdHVJp72Zj WF+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=6Gdvl1M/luW54GYkHIs3SPr6ULelgEvVHe6O5yMMnyI=; b=upC1XI1LajIxOSVF/eq1k6OnIuX3prM8iOBtJYcUcrgzVTekwHcC1u0pYIoRbEZ6dH dBFCBDyN6Umb8da1xOo62wNZ9JLfDDp8dbqZQj0YFclXzcZ9V7sEzC5NrMvAndxpmcht i195s2/zN/BKjcN2CNVaGNQqNuc3T/DEpRC14AHQCTg45ySJDSPZSem99jcjTeUftlsc MensbZE+tQifEZX4vEmlvIhzxfMPJGQIbMYtANKiM5inwWd9TtzsLUxQe2KoahhxX+Ck tsFmkGp9hshTeSTJFPcnKYsJr4En/5rv/g45dTpPuta8ciLFANu/Sx2ctdJpt4/6VTpr y+NQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c70si38078543pfc.270.2019.08.01.21.58.07; Thu, 01 Aug 2019 21:58:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389375AbfHAWPQ (ORCPT + 99 others); Thu, 1 Aug 2019 18:15:16 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33778 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727987AbfHAWPP (ORCPT ); Thu, 1 Aug 2019 18:15:15 -0400 Received: from localhost (unknown [172.58.27.22]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6D5B915434E2B; Thu, 1 Aug 2019 15:15:14 -0700 (PDT) Date: Thu, 01 Aug 2019 18:15:08 -0400 (EDT) Message-Id: <20190801.181508.657295078853071495.davem@davemloft.net> To: takondra@cisco.com Cc: jon.maloy@ericsson.com, ying.xue@windriver.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, xe-linux-external@cisco.com, stable@vger.kernel.org Subject: Re: [PATCH] tipc: compat: allow tipc commands without arguments From: David Miller In-Reply-To: <20190729221507.48893-1-takondra@cisco.com> References: <20190729221507.48893-1-takondra@cisco.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 01 Aug 2019 15:15:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Taras Kondratiuk Date: Mon, 29 Jul 2019 22:15:07 +0000 > Commit 2753ca5d9009 ("tipc: fix uninit-value in tipc_nl_compat_doit") > broke older tipc tools that use compat interface (e.g. tipc-config from > tipcutils package): ... > This patch relaxes the original fix and rejects messages without > arguments only if such arguments are expected by a command (reg_type is > non zero). > > Fixes: 2753ca5d9009 ("tipc: fix uninit-value in tipc_nl_compat_doit") > Signed-off-by: Taras Kondratiuk > --- > The patch is based on v5.3-rc2. Applied and queued up for -stable.