Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp609838ybi; Fri, 2 Aug 2019 01:17:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzypWg4YtyKnFU4qXglVxyGfw3f3EePhh6MBfYdPMGy/VXG2fJ03IwbMaAlTnk8hOisv3l X-Received: by 2002:a63:67c6:: with SMTP id b189mr32192716pgc.163.1564733862734; Fri, 02 Aug 2019 01:17:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564733862; cv=none; d=google.com; s=arc-20160816; b=KkyT+7ZNG7HgVlXlw8Jq9N9BGPJv6A9OGyZJejpTkmZKbx55tY7iOzp1Q8crLQemiE OIqUmI7eIiKPTgelANW9HDevlQ5o417o2f7QxDmFpq8ymtO6M0B/nEJL/e8Qmo66FRP6 UbwmT35wKyxbdWCmv2M7doguo3GsA+OwUWTHZoDlaNcvXZp7p8lzgOjnsFtGCK2G8uVe 1ESYSLhIXtf2aKC9xHpUJaXfpBL32wXmX3RXfXGL5CIfnynbZ8tZc/LvtnzAoKDQfa1K 63omlXDOWwQASJJlQyFCnWYOayjEkmgAlYo9WacFtFQd20ZEEoZ33x5ovWCGwcs5Zugf +xOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=yhrUg3JwjW6mF8jjGJnjsfQuSYgZFyclQ9ZsBMqO+UI=; b=YEyD1rv1PJRk7iXJGCRZAnvqCoXXApA5jbX15WFlKxFUBZCaXLhCJUEhMAh/SXHbT/ ujYLMvkxr67f1PRIDgzz9MdFamhyGTCHAGGiF7VQ4cHewZ43YqXqWkuVFDHji0gqSyPg /DlDNwaTQ6HBRf0GMpmY6XyGr/HXpfld8Bkt86hGSYV/epjkUBb13UFRqWaGuS4mcpNB Fb8hkhWMxCZ+WEGrLaN/T1qFGxlw1PpCm7icoe5X2o/5ws9Dp9C3JBeX8VvJMI+bGZ/q vb380CJk0iiHAEDPkzrpbOgoycg3pWZNW1Z7jkpG/csBn2SigxLaeBVaRJ44mTjHPReH NPnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c16si6287237pjq.20.2019.08.02.01.17.26; Fri, 02 Aug 2019 01:17:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727738AbfHBC20 (ORCPT + 99 others); Thu, 1 Aug 2019 22:28:26 -0400 Received: from ozlabs.org ([203.11.71.1]:42535 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728729AbfHBC2Y (ORCPT ); Thu, 1 Aug 2019 22:28:24 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 460B0k6y1Hz9sDB; Fri, 2 Aug 2019 12:28:22 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 7440ea8b2a4430eef5120d0a7faac6c39304ae6d In-Reply-To: <20190730143704.060a2606@canb.auug.org.au> To: Stephen Rothwell , Benjamin Herrenschmidt From: Michael Ellerman Cc: Linux kernel Mailing List , PowerPC , Kees Cook , "Gustavo A. R. Silva" Subject: Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through Message-Id: <460B0k6y1Hz9sDB@ozlabs.org> Date: Fri, 2 Aug 2019 12:28:22 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-07-30 at 04:37:04 UTC, Stephen Rothwell wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: powerpc): > > drivers/macintosh/smu.c: In function 'smu_queue_i2c': > drivers/macintosh/smu.c:854:21: warning: this statement may fall through [-= > Wimplicit-fallthrough=3D] > cmd->info.devaddr &=3D 0xfe; > ~~~~~~~~~~~~~~~~~~^~~~~~~ > drivers/macintosh/smu.c:855:2: note: here > case SMU_I2C_TRANSFER_STDSUB: > ^~~~ > > Cc: Benjamin Herrenschmidt > Cc: Gustavo A. R. Silva > Cc: Kees Cook > Signed-off-by: Stephen Rothwell Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/7440ea8b2a4430eef5120d0a7faac6c39304ae6d cheers