Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp686607ybi; Fri, 2 Aug 2019 02:36:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwv6jnFQHn9VvWo5BUOQk/dxZLqCBR6D1BR36z/a0B8zHZKJ5HLikqftc8LZTLACEZpgfVy X-Received: by 2002:a17:902:b944:: with SMTP id h4mr53877789pls.179.1564738605407; Fri, 02 Aug 2019 02:36:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564738605; cv=none; d=google.com; s=arc-20160816; b=SdQ1CVgmkrZp26+6E446Wy3lhJJW8oyHwfePGie9WD4bEryLj438QxtHaq24yhdvFR M5R2cmTYNtWQ8WEs7zvq0b8CZKWw35ZFb8Sx3wd5VhnhI8FxClr5ycsQrQO4fgZZdqfM fgmnaYoM0jEP7+B8gT7+ZF2xKiU2qVkI6j/n9KtR2e4pnfxJA90ibgqyEvLUc9O8OFVe 2oyl1+dYJTbOxLGVCfDnWs1+f9PyHypKALL/1+Cx5ykFY56LCZeDsmVaCxLbwY1e7jmB UAuAUQHGzxpS7HSbKd9AiI3ZHVZP0OdqUk4W4H4ZvQZnOqPDl9685Q8ybiZDdyCDrXKR LdEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Ievm/oR99l3iLaISaRwUEhXWF6M8SDlQwub6ftDBThA=; b=V5WIebyDPICh1F4T368PyALDSgYiHSy047sg2v19YkOoi3VoZN3XHpqcykQCYC7h5H HtojvWK6t09rRSehtTTxscpWbwdKK1g0+QqYKKf0v7m/3TjLswXD/XMqkKIpRy3KNB4y DyOUo1b7lINpZAx/BRJSemCMJvpdQsMVNhyNFEJQVck+gDCxBAYsQzs9crciZWQSniMp Z963/pJTgKkVCI9AlBD3fjcDyQNpP5UImZzPxuk7r0FKMVJg+jbqUgiBcrpApEkv7OKr SetNS8q6PuLvWrcgqM9eLtVFcw/f/CPLugnixPswIoJIXnGOySlMpU75b0bEpI8rdksq v1dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t25si37298438pgl.7.2019.08.02.02.36.29; Fri, 02 Aug 2019 02:36:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404012AbfHBIVf (ORCPT + 99 others); Fri, 2 Aug 2019 04:21:35 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:33107 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727008AbfHBIVf (ORCPT ); Fri, 2 Aug 2019 04:21:35 -0400 Received: from LHREML713-CAH.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 367D3321756B743FA386; Fri, 2 Aug 2019 09:21:33 +0100 (IST) Received: from [10.220.133.57] (10.220.133.57) by smtpsuk.huawei.com (10.201.108.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Aug 2019 09:21:25 +0100 Subject: Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated To: Jarkko Sakkinen CC: , , , , , , , , , , References: <20190705163735.11539-1-roberto.sassu@huawei.com> <20190711194811.rfsohbfc3a7carpa@linux.intel.com> <20190801163215.mfkagoafkxscesne@linux.intel.com> From: Roberto Sassu Message-ID: Date: Fri, 2 Aug 2019 10:21:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190801163215.mfkagoafkxscesne@linux.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.220.133.57] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/2019 6:32 PM, Jarkko Sakkinen wrote: > On Mon, Jul 15, 2019 at 06:44:28PM +0200, Roberto Sassu wrote: >> According to the bug report at https://bugs.archlinux.org/task/62678, >> the trusted module is a dependency of the ecryptfs module. We should >> load the trusted module even if the TPM is inactive or deactivated. >> >> Given that commit 782779b60faa ("tpm: Actually fail on TPM errors during >> "get random"") changes the return code of tpm_get_random(), the patch >> should be modified to ignore the -EIO error. I will send a new version. > > Do you have information where this dependency comes from? ecryptfs retrieves the encryption key from encrypted keys (see ecryptfs_get_encrypted_key()). Roberto -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Li Peng, Li Jian, Shi Yanli