Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before
 goto
To:     Michal Simek <michal.simek@xilinx.com>, jassisinghbrar@gmail.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <20190709172841.13769-1-nishkadg.linux@gmail.com>
 <eaf1fcbe-615e-0fec-d330-ae94e8f3c102@xilinx.com>
 <6a5306bd-946d-383f-0b42-f17675c24218@gmail.com>
 <c0be80c9-16ef-fe03-ae3b-a7d3d1a2ede8@xilinx.com>
From:   Nishka Dasgupta <nishkadg.linux@gmail.com>
Message-ID: <ab6db31d-ff16-5a32-f097-347daa6b98fc@gmail.com>
Date:   Fri, 2 Aug 2019 10:29:49 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <c0be80c9-16ef-fe03-ae3b-a7d3d1a2ede8@xilinx.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 31/07/19 7:51 PM, Michal Simek wrote:
> On 31. 07. 19 15:06, Nishka Dasgupta wrote:
>> On 31/07/19 2:01 PM, Michal Simek wrote:
>>> On 09. 07. 19 19:28, Nishka Dasgupta wrote:
>>>> Each iteration of for_each_available_child_of_node puts the previous
>>>> node, but in the case of a goto from the middle of the loop, there is
>>>> no put, thus causing a memory leak. Hence add an of_node_put before the
>>>> goto.
>>>> Issue found with Coccinelle.
>>>>
>>>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>>>> ---
>>>>    drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>> b/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>> index 86887c9a349a..bd80d4c10ec2 100644
>>>> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
>>>> @@ -661,6 +661,7 @@ static int zynqmp_ipi_probe(struct
>>>> platform_device *pdev)
>>>>            if (ret) {
>>>>                dev_err(dev, "failed to probe subdev.\n");
>>>>                ret = -EINVAL;
>>>> +            of_node_put(nc);
>>>>                goto free_mbox_dev;
>>>>            }
>>>>            mbox++;
>>>>
>>>
>>> Patch is good but when you are saying that this was found by Coccinelle
>>> then it should be added as script to kernel to detect it.
>>
>> This particular patch was suggested by a script I did not write myself;
>> someone else wrote it and sent it to me. How should I proceed in this case?
> 
> You can ask him to submit it to kernel.
> Or you can take it, keep his authorship and send it to:

I have asked her to submit this script, thank you. Will I need to 
resubmit this patch, however?

Regards,
Nishka

> ./scripts/get_maintainer.pl -f scripts/coccinelle/
> Julia Lawall <Julia.Lawall@lip6.fr> (supporter:COCCINELLE/Semantic
> Patches (SmPL))
> Gilles Muller <Gilles.Muller@lip6.fr> (supporter:COCCINELLE/Semantic
> Patches (SmPL))
> Nicolas Palix <nicolas.palix@imag.fr> (supporter:COCCINELLE/Semantic
> Patches (SmPL))
> Michal Marek <michal.lkml@markovi.net> (supporter:COCCINELLE/Semantic
> Patches (SmPL))
> cocci@systeme.lip6.fr (moderated list:COCCINELLE/Semantic Patches (SmPL))
> linux-kernel@vger.kernel.org (open list)
> 
> Thanks,
> Michal
>