Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Christophe de Dinechin <christophe.de.dinechin@gmail.com>
References: <1564479235-25074-1-git-send-email-wanpengli@tencent.com> <04700afaf68114b5ab329f5a5182e21578c15795.camel@suse.com>
User-agent: mu4e 1.3.2; emacs 26.2
To:     Dario Faggioli <dfaggioli@suse.com>
Cc:     Wanpeng Li <kernellwp@gmail.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] KVM: Disable wake-affine vCPU process to mitigate lock holder preemption
In-reply-to: <04700afaf68114b5ab329f5a5182e21578c15795.camel@suse.com>
Date:   Fri, 02 Aug 2019 10:30:11 +0200
Message-ID: <7h7e7wkm0c.fsf@crazypad.dinechin.lan>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Dario Faggioli writes:

> On Tue, 2019-07-30 at 17:33 +0800, Wanpeng Li wrote:
>> However, in multiple VMs over-subscribe virtualization scenario, it
>> increases 
>> the probability to incur vCPU stacking which means that the sibling
>> vCPUs from 
>> the same VM will be stacked on one pCPU. I test three 80 vCPUs VMs
>> running on 
>> one 80 pCPUs Skylake server(PLE is supported), the ebizzy score can
>> increase 17% 
>> after disabling wake-affine for vCPU process. 
>> 
> Can't we achieve this by removing SD_WAKE_AFFINE from the relevant
> scheduling domains? By acting on
> /proc/sys/kernel/sched_domain/cpuX/domainY/flags, I mean?
>
> Of course this will impact all tasks, not only KVM vcpus. But if the
> host does KVM only anyway...

Even a host dedicated to KVM has many non-KVM processes. I suspect an
increasing number of hosts will be split between VMs and containers.

>
> Regards


-- 
Cheers,
Christophe de Dinechin