Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1144781ybi; Fri, 2 Aug 2019 10:02:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqysGgkdPwVD4KAgC+f+/c8bEhkSkl+TGDmu8n6oWoZw8H5rICINjA1qyOLDCxNH/XWUE6G7 X-Received: by 2002:a17:902:54d:: with SMTP id 71mr129105559plf.140.1564765333106; Fri, 02 Aug 2019 10:02:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564765333; cv=none; d=google.com; s=arc-20160816; b=jOe75meJlsrUh5CVsfzHYXLMcIurvJhp01IENPGeMIG0HcX9BQJYj/JpcYjW8023Tm oLWsitOjSvZ9g5TBvlhtnBO8WFMINl9NipW5NaSD4dl64VbDDK7DAi4hcwLvaTPjGyBg YzbKz/Ev0sgLY74/TlimIkW/0hcsoQfhnrfqK8Fzx7c+wy92EruyHcrs8GUYb/VspMhJ QeyF55q7Z8tQHlypzWAsNyZfBm3YXV3zYJZlpSDx1tbYNePFmQP1wZ+mltx39ddArUHg YJQRIVfgm9mt0tVcJdSXMhTysk6kJIMj02v+a501dqgkA/zQ1h2r8eNxnyrULJhJPakt DEDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2yyP2VcqoqBMqXLFT/FcxHd8TzNX5dcnnJv/qcoVm6I=; b=fi8FQcb++emrMXzMIP5Jvmxcs4WjZUKUkVOZgjdtOqBk8Q5aWMZK1wWDxV+h0pianz Ki9CwaPvJ2f4VPrO7E1y2vuATD5nFo9n+VKSSpMn00iImgbmuujunstdmsfkyP6aGWJN rOjW/q6rTmkquJCGaNZSKoOYmvWggdPG1vUN9fECyQcydXr83tebqyWzIFOUBwT4sruA 07A24YwGi8Uk27wnRgjcxtxC6PDfYbmt6Wnuq7HNCQkEy4D1GWk8HoGhCNBu2Gia/Tr3 Kho8GPOyMEAc6JrF9txwteJkmNxr4bOYjBq+KWWrjAvUjnzvtoC2ZNGu+wRqys+w3EsA S0jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HY3qMyQw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x10si40435894pfj.93.2019.08.02.10.01.57; Fri, 02 Aug 2019 10:02:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HY3qMyQw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405182AbfHBJoL (ORCPT + 99 others); Fri, 2 Aug 2019 05:44:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:47394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387493AbfHBJoK (ORCPT ); Fri, 2 Aug 2019 05:44:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49183206A2; Fri, 2 Aug 2019 09:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564739049; bh=ZgwQnHW9qbACH2wauFG8EO9BfA2QDmU0QRpAI0NIdI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HY3qMyQwHsoTgKe8m9az3WUcu20qjGwqZ2RuXyMRpJ3VAyAx/WywUQyAJtGn636yn RhEyZnjc/UX6EtyYedhwLoA6gYhnPNdYxzznDBrtrxnpE6EvLwCYxA92qOZq0cHfOE RzZlIolDyaK3TyE58Iar6LN0TkXBYIIycU4hyyFI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Philipp Zabel , Ezequiel Garcia , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.9 093/223] media: coda: Remove unbalanced and unneeded mutex unlock Date: Fri, 2 Aug 2019 11:35:18 +0200 Message-Id: <20190802092245.161106923@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190802092238.692035242@linuxfoundation.org> References: <20190802092238.692035242@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ezequiel Garcia commit 766b9b168f6c75c350dd87c3e0bc6a9b322f0013 upstream. The mutex unlock in the threaded interrupt handler is not paired with any mutex lock. Remove it. This bug has been here for a really long time, so it applies to any stable repo. Reviewed-by: Philipp Zabel Signed-off-by: Ezequiel Garcia Signed-off-by: Hans Verkuil Cc: stable@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/coda/coda-bit.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -2107,7 +2107,6 @@ irqreturn_t coda_irq_handler(int irq, vo if (ctx == NULL) { v4l2_err(&dev->v4l2_dev, "Instance released before the end of transaction\n"); - mutex_unlock(&dev->coda_mutex); return IRQ_HANDLED; }