Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1411341ybi; Fri, 2 Aug 2019 15:16:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVwf/nuoM+YvmRtKgQZ7DDdes5PekO63kH7AyWNnfSJiyC00cCgQJ0waHXL+siVp0Kxrk3 X-Received: by 2002:a62:1ac9:: with SMTP id a192mr21700200pfa.260.1564784161129; Fri, 02 Aug 2019 15:16:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564784161; cv=none; d=google.com; s=arc-20160816; b=WtWMjdL6fgBkGn8fqj21uDT9ZwmLHSVAWdNGr09W/k8RoIfcSjcS5PzwZs8F+KGfl7 K94P/dsWfovNZt0CaYmZ/wRAGkOvkpTNR20KtAJ5Nb3P01YV0BAbf/qbGXFbRsyKfRZB sfIkprI4L41lBmwnrqkZnq/zrd9fIJ/+EnOFL/Y2pwfqfm8o+UaoFX2lbhsno+ze/7JM MFpImtCM22Bd/Ft3jTLEcw+/LqlFnBz8taoJQYZzHgHYX2+GzXwp7evpHmD5fkTCoYcN 0vIIM2mmpgTMLjzctBRxJ+o6PRlTZ5bpEOSRK8ZIN68FxUg2VUTloLYlSmAmMYFivWNB wVwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=/GObCnouG/oRPlWnXNRH3ae1iTlxgOy4Dg/E2yNrZ8k=; b=twG8UmI27eag9UkHLefQ1dcjennDe7Di3yzri3isn50UxQk9caHjX7C26HM7TLrfyl Qo7TSSyECCXykl0mO3ohe2G326+/8po5zC24abxXuxVjHtCUupgDRR2Sk4EISk6r2+mD olwyQ9SnQ6I0aJrdv+5JuA8F19nBHzY8/jpwu34ZlFTUElFX8vJxfO3FypcuqPR/1V+D BYz4NbxpdlfJDAqIvMbvKPPFLwVNGCFwHoLbh3UnUetZhtirQIaS3rclbcWqv2hlHYcD 1wH8wLyYVWswvtM4CQdgxp7UFk+6rfoQl7EhidgvuzZ68VP4U+cramBgXd/vfJqPKRaL iw5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1si39210636pfi.139.2019.08.02.15.15.45; Fri, 02 Aug 2019 15:16:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391581AbfHBMQB (ORCPT + 99 others); Fri, 2 Aug 2019 08:16:01 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:51873 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732085AbfHBMQB (ORCPT ); Fri, 2 Aug 2019 08:16:01 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1htWTU-00081H-RR; Fri, 02 Aug 2019 14:15:56 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1htWTT-000728-QG; Fri, 02 Aug 2019 14:15:55 +0200 Date: Fri, 2 Aug 2019 14:15:55 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Schrempf Frieder Cc: "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-imx@nxp.com" , "geert+renesas@glider.be" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Jiri Slaby , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 4/4] serial: 8250: Don't check for mctrl_gpio_init() returning -ENOSYS Message-ID: <20190802121555.dl6rpjphgaxdvcke@pengutronix.de> References: <20190802100349.8659-1-frieder.schrempf@kontron.de> <20190802100349.8659-4-frieder.schrempf@kontron.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190802100349.8659-4-frieder.schrempf@kontron.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 02, 2019 at 10:04:11AM +0000, Schrempf Frieder wrote: > From: Frieder Schrempf > > Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS) > if CONFIG_GPIOLIB is disabled, we can safely remove this check. > > Signed-off-by: Frieder Schrempf Acked-by: Uwe Kleine-K?nig @greg: This patch doesn't depend on patch 2; ditto for patch 3. So only taking patches 1, 3 and 4 should be fine. This way Frieder's v4 only have to care for patch 2. (Assuming noone objects to 1, 3 and 4 of course.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |