Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 2 Aug 2019 14:34:18 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Neil Horman <nhorman@tuxdriver.com>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Joe Perches <joe@perches.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "Gustavo A . R . Silva" <gustavo@embeddedor.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Shawn Landden <shawn@git.icu>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo
 keyword for switch/case use
Message-ID: <20190802123418.GA3722@amd>
References: <ccc7fa72d0f83ddd62067092b105bd801479004b.camel@perches.com>
 <765E740C-4259-4835-A58D-432006628BAC@zytor.com>
 <20190731184832.GZ31381@hirez.programming.kicks-ass.net>
 <F1AB2846-CA91-41ED-B8E7-3799895DCF06@zytor.com>
 <CANiq72=s1nu9=R9ypFwL+J4NGT_yUkwahpgOOOXzezvNfDrx5g@mail.gmail.com>
 <F2529DE6-B500-44DC-AE72-45A304AD719B@zytor.com>
 <20190801122429.GY31398@hirez.programming.kicks-ass.net>
 <0BCDEED9-0B72-4412-909F-76C20D54983E@zytor.com>
 <CANiq72kg+duBe_srpcco-P17=3OC2c1ys=rGMVY8Z9FxZ69sdw@mail.gmail.com>
 <20190802110042.GA6957@hmswarspite.think-freely.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X"
Content-Disposition: inline
In-Reply-To: <20190802110042.GA6957@hmswarspite.think-freely.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--LZvS9be/3tNcYl/X
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri 2019-08-02 07:00:42, Neil Horman wrote:
> On Thu, Aug 01, 2019 at 10:26:29PM +0200, Miguel Ojeda wrote:
> > On Thu, Aug 1, 2019 at 10:10 PM <hpa@zytor.com> wrote:
> > >
> > > I'm not disagreeing... I think using a macro makes sense.
> >=20
> > It is either a macro or waiting for 5+ years (while we keep using the
> > comment style) :-)
> >=20
> > In case it helps to make one's mind about whether to go for it or not,
> > I summarized the advantages and a few other details in the patch I
> > sent in October:
> >=20
> >   https://github.com/ojeda/linux/commit/668f011a2706ea555987e263f609a5d=
eba9c7fc4
> >=20
> > It would be nice, however, to discuss whether we want __fallthrough or
> > fallthrough. The former is consistent with the rest of compiler
> > attributes and makes it clear it is not a keyword, the latter is
> > consistent with "break", "goto" and "return", as Joe's patch explains.
> >=20
> I was having this conversation with Joe, and I agree, I like the idea of
> macroing up the fall through attribute, but naming it __fallthrough seems=
 more
> consistent to me with the other attribute macros.  I also feel like its m=
ore
> recognizable as a macro.  Naming it fallthrough just makes it look like s=
omeone
> forgot to put /**/'s around it to me.

I like the "fallthrough". It looks like "return" and it should, no
need to have __'s there..
									Pavel
--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--LZvS9be/3tNcYl/X
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAl1ELcoACgkQMOfwapXb+vK1hACffs8mCIfAXurkFvMKZ6v2UemF
TskAn3GYO/De+EJw1nUoQq6PMRxy3zVb
=Akck
-----END PGP SIGNATURE-----

--LZvS9be/3tNcYl/X--