Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190802104628.8410-1-qais.yousef@arm.com>
In-Reply-To: <20190802104628.8410-1-qais.yousef@arm.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Fri, 2 Aug 2019 15:19:02 +0200
Message-ID: <CAKfTPtDxuwhnSrHDK4hq86wEu2JP8OwXVb_TQbo5UL9D+fkoJQ@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: schedutil: fix equation in comment
To:     Qais Yousef <qais.yousef@arm.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Ingo Molnar <mingo@redhat.com>,
        "open list:THERMAL" <linux-pm@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2 Aug 2019 at 12:46, Qais Yousef <qais.yousef@arm.com> wrote:
>
> scale_irq_capacity() call in schedutil_cpu_util() does
>
>         util *= (max - irq)
>         util /= max
>
> But the comment says
>
>         util *= (1 - irq)
>         util /= max
>
> Fix the comment to match what the scaling function does.
>
> Signed-off-by: Qais Yousef <qais.yousef@arm.com>

FWIW
Acked-by:  Vincent Guittot <vincent.guittot@linaro.org>
> ---
>  kernel/sched/cpufreq_schedutil.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index 636ca6f88c8e..e127d89d5974 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -259,9 +259,9 @@ unsigned long schedutil_cpu_util(int cpu, unsigned long util_cfs,
>          * irq metric. Because IRQ/steal time is hidden from the task clock we
>          * need to scale the task numbers:
>          *
> -        *              1 - irq
> -        *   U' = irq + ------- * U
> -        *                max
> +        *              max - irq
> +        *   U' = irq + --------- * U
> +        *                 max
>          */
>         util = scale_irq_capacity(util, irq, max);
>         util += irq;
> --
> 2.17.1
>