Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp637298ybh; Sat, 3 Aug 2019 06:43:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLCLLCn03RZcMi085Q0BPMXEB/YMzQiRAiqROwEZOXOy/72gvpqWImspqq+N0Ph6D8ykKT X-Received: by 2002:aa7:9481:: with SMTP id z1mr65043479pfk.92.1564839829658; Sat, 03 Aug 2019 06:43:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564839829; cv=none; d=google.com; s=arc-20160816; b=AcXKdIuFZpHg203bPHoAeyfSxhBLG/QjcV+i1HsbNH8598jmXFcSL5av717YEYO1vC /AHNmAgE3GomUY37LXO42Coh6/rSNHa3+SmeA5uPWUY7WvHP6KaUYApVMFRSZz5/4uJE P2tGQsqV9R1bjgnHbbJF6XxxxCLYi2HFg69UZkJMnaEh9/4zqKFsFiKBk/e5w5GOkgLy 3X7fMgEXIHdAr1YX5fEbJfiYd6fRG0WhkMvz+V+KTsatRmZc6DBFRsTyJVA7Y8jBH08W /joYtv2nLIw7BoFtwUcadqtWK3fg1GfNJhLwVDrwkdg7wDt7ulA1LicVgdP+74Pw0zxZ p3UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:openpgp:from:references:cc:to:subject; bh=3i+v6PWLAFY4pLYnR68bLFCR3VGy3PuSRw0b9/MCRls=; b=CxHNTZz1ZBi44+hB/QbEYwOzINjzUeRWEbYPLruK3Bp21jxwtmpa4jMZ52mNbD2l2S /m1HtVcFHuA76c5NGC7oPf865k2W6wqMhVmkhyJNbGI29QdOykfQYqIU2QHoSFHtKZeW ljY3p5Ls72noui1Wb3LMT426pB7phLf7XGWpkpvrYlAIpDlFcyYAu0vahuP3x/+i/xEB S8/IvSalCRCvw6QMGEUk5O10cITEbRX59dKBRjNjmDU54MWN93ebTj5ceENmS8tbY/J9 pcyThC1DfW9hMD+uF4MLRP49NV6qSENNmXWs5Cnwg+VjJVzUwMdIe6/gkvi0F9Oajpxt tp7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x9si38403053plo.98.2019.08.03.06.43.34; Sat, 03 Aug 2019 06:43:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406568AbfHBNnk (ORCPT + 99 others); Fri, 2 Aug 2019 09:43:40 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41342 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405207AbfHBNnk (ORCPT ); Fri, 2 Aug 2019 09:43:40 -0400 Received: by mail-wr1-f65.google.com with SMTP id c2so74009677wrm.8 for ; Fri, 02 Aug 2019 06:43:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3i+v6PWLAFY4pLYnR68bLFCR3VGy3PuSRw0b9/MCRls=; b=W5WddeVeyFomvegKGutR3Hhll6KFmGf6LHS71UM9KJRksnw5lFnzC6i12zrr1HkCrh c2g/VTg6d84BLTBk+76pAu9SzIUB+e6tojpDfgNuUWZuslePvU/LNi1DW6VtnBS85B54 3yxL3hL219TquhV6s8KpUdmtKhuw5uu50M6VCfbq4rH4vfHK76W35k+z1T0ctKTeo/K9 V0rJ1a+t92l3Eb/Wd8wACFDm4wkmsDx0Bk3Ke/vIWNveHyCT3m979gAzzsx6S7btHxAB GniI29dD0YoNx6sSJrTHSor+RUY6jA+Qj4TzmlEw7tsj3cucCvi1LKCpDxFlwdbPbSV4 tbuw== X-Gm-Message-State: APjAAAWFsBMrnHetcf2dBc7VwNnYl1zvb2Sk1yd8rBG6gF+zlXeSZZVu Caee0BhySelG3DTfoeC9uP50bw== X-Received: by 2002:adf:df8b:: with SMTP id z11mr89917522wrl.62.1564753418003; Fri, 02 Aug 2019 06:43:38 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:4013:e920:9388:c3ff? ([2001:b07:6468:f312:4013:e920:9388:c3ff]) by smtp.gmail.com with ESMTPSA id r123sm70327253wme.7.2019.08.02.06.43.37 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 02 Aug 2019 06:43:37 -0700 (PDT) Subject: Re: [PATCH v3 0/3] KVM: selftests: Enable ucall and dirty_log_test on s390x To: Christian Borntraeger , Thomas Huth , kvm@vger.kernel.org Cc: Janosch Frank , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, David Hildenbrand , Peter Xu , Andrew Jones References: <20190731151525.17156-1-thuth@redhat.com> <551b42ae-78a1-e55a-e4b8-bb5cc3a8eb8b@de.ibm.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <9684b15d-39a4-2c1b-3269-466ceb37ef90@redhat.com> Date: Fri, 2 Aug 2019 15:43:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <551b42ae-78a1-e55a-e4b8-bb5cc3a8eb8b@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/19 15:39, Christian Borntraeger wrote: > On 31.07.19 17:15, Thomas Huth wrote: >> Implement the ucall() interface on s390x to be able to use the >> dirty_log_test KVM selftest on s390x, too. >> >> v3: >> - Fix compilation issue on aarch64 (thanks to Andrew for testing it!) >> - Added Reviewed-bys >> >> v2: >> - Split up ucall.c into architecture specific files >> - Removed some #ifdef __s390x__ in the dirty_log patch >> >> Thomas Huth (3): >> KVM: selftests: Split ucall.c into architecture specific files >> KVM: selftests: Implement ucall() for s390x >> KVM: selftests: Enable dirty_log_test on s390x >> >> tools/testing/selftests/kvm/Makefile | 9 +- >> tools/testing/selftests/kvm/dirty_log_test.c | 61 ++++++- >> .../testing/selftests/kvm/include/kvm_util.h | 8 +- >> .../testing/selftests/kvm/lib/aarch64/ucall.c | 112 +++++++++++++ >> tools/testing/selftests/kvm/lib/s390x/ucall.c | 56 +++++++ >> tools/testing/selftests/kvm/lib/ucall.c | 157 ------------------ >> .../testing/selftests/kvm/lib/x86_64/ucall.c | 56 +++++++ >> .../selftests/kvm/s390x/sync_regs_test.c | 6 +- >> 8 files changed, 287 insertions(+), 178 deletions(-) >> create mode 100644 tools/testing/selftests/kvm/lib/aarch64/ucall.c >> create mode 100644 tools/testing/selftests/kvm/lib/s390x/ucall.c >> delete mode 100644 tools/testing/selftests/kvm/lib/ucall.c >> create mode 100644 tools/testing/selftests/kvm/lib/x86_64/ucall.c >> > > Paolo, I guess you do not mind if I carry patch 1 also via the s390x tree? Sure, Acked-by: Paolo Bonzini Paolo