Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp669552ybh; Sat, 3 Aug 2019 07:21:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqzOBgk5Cq8QntM48OzNZ7BR9uot7iqXshxYX6asgAWfBxP3MRsv5JCgvxt+v1mP/4COCI8v X-Received: by 2002:a65:640a:: with SMTP id a10mr127031735pgv.338.1564842107569; Sat, 03 Aug 2019 07:21:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564842107; cv=none; d=google.com; s=arc-20160816; b=q9+Y1jvRUXYD6BAM46H34eDbONJVfAkhdUPx6c4yvAlGKqcTLSODSdx5IKPvMJjBV8 wPAjAiKExefiLvMgNarTNzeEmq43k0KrfYSGHEKlk/1bAcMp8jsQAiaxO8O2wY94k06D iVJCTRpzDOe3CXxxt0fYkc0Ubk2PtNfvtDMjDH5+Ie79ZaHb2miI9C4KSGPslyen8oUG uPWyGEGkXKh8wvMyfs6EmK54raS3NwedMQMpVw5gQpvmLVyGicwhHXJFyJYCZZbPFQlm EzjHQgIfTZ6KR5vrexNKmvuvqGQ+6CqvTq3/Fa5R530U/tP+4e4sbFM2iJXbUkmSwmeX NyRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=BFiuuDlzpgt4PUU8WkqgjsF+utGR5wizMbcDK/5M6g0=; b=0utj9JfA9ZvjvMb+u94FilBCJY63T7UHnO8maOZhq+lFs2OsB95xTzfuTnM3jzNXQ5 sx5xpH5xGU9ttpy9lFENaWi4hTXC1Ml1eFsbVAoHwvVIvvL6EbzMe4qTCl+qSUw3JcF4 whESojDyOYQ6va/hww1oW48ySOkdSCRDEsQtG+nCehXpb+dzjr0kID1Y1UxcuyBTREDn HGGlNzwZ7oLOarS2JRUXftJkFcGNCGzemg7z2QNMIZXOpgoaf8Q57acUuVnzwZQJqi7y bdKmAx0q/uL5i3ZQxMPUTkVRs9yBKa/P+cfxQhCQp0Yms4hmRxUoQepTtg4dBuclG0+d gYmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y62si13738450pgy.348.2019.08.03.07.21.32; Sat, 03 Aug 2019 07:21:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395086AbfHBOvT (ORCPT + 99 others); Fri, 2 Aug 2019 10:51:19 -0400 Received: from imap1.codethink.co.uk ([176.9.8.82]:53233 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395080AbfHBOvR (ORCPT ); Fri, 2 Aug 2019 10:51:17 -0400 Received: from [167.98.27.226] (helo=[10.35.6.253]) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1htYti-0008AU-Oe; Fri, 02 Aug 2019 15:51:10 +0100 Subject: Re: [alsa-devel] [PATCH v2 3/3] ASoC: TDA7802: Add turn-on diagnostic routine To: Mark Brown Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Charles Keepax , Kuninori Morimoto , Kirill Marinushkin , Liam Girdwood , Marco Felsch , Annaliese McDermond , Takashi Iwai , Paul Cercueil , Vinod Koul , Rob Herring , Srinivas Kandagatla , Jerome Brunet , linux-kernel@vger.kernel.org, Cheng-Yi Chiang References: <20190730120937.16271-1-thomas.preston@codethink.co.uk> <20190730120937.16271-4-thomas.preston@codethink.co.uk> <20190730141935.GF4264@sirena.org.uk> <45156592-a90f-b4f8-4d30-9631c03f1280@codethink.co.uk> <20190730155027.GJ4264@sirena.org.uk> <9b47a360-3b62-b968-b8d5-8639dc4b468d@codethink.co.uk> <20190801234241.GG5488@sirena.org.uk> <472cc4ee-2e80-8b08-d842-79c65df572f3@codethink.co.uk> <20190802111036.GB5387@sirena.org.uk> From: Thomas Preston Message-ID: Date: Fri, 2 Aug 2019 15:51:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190802111036.GB5387@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2019 12:10, Mark Brown wrote: > On Fri, Aug 02, 2019 at 09:32:17AM +0100, Thomas Preston wrote: >> On 02/08/2019 00:42, Mark Brown wrote: > >>> Yes, that's definitely doable - we've got some other drivers with >>> similar things like calibration triggers exposed that way. > >> One problem with using a kcontrol as a trigger for the turn-on diagnostic >> is that the diagnostic routine has a "return value". > > You can use a read only control for the readback, or just have it be > triggered by overwriting the readback value. You can cache the result. > Keeping the trigger and result together like that would be better I think, although the routine isn't supposed to run mid way through playback. If we're mid playback the debugfs routine has to turn off AMP_ON, take the device back to a known state, run diagnostics, then restore. Which causes a gap in the audible sound. >> Hm, maybe a better idea is to have the turn on diagnostic only run on >> device probe (as its name suggests!), and print something to dmesg: > >> modprobe tda7802 turn_on_diagnostic=1 > >> tda7802-codec i2c-TDA7802:00: Turn on diagnostic 04 04 04 04 > >> Kirill Marinushkin mentioned this in the first review [0], it just didn't >> really sink in until now! > > You could do that too, yeah. Depends on what this is diagnosing and if > that'd be useful. > The diagnostic status bits describe situations such as: - open load (no speaker connected) - short to GND - short to VCC - etc The intention is to test if all the speakers are connected. So, one might have a self test which runs the diagnostic and verifies it outputs: 00 00 00 00 For example, on my test rig there is only one speaker connected. So it reads: 04 04 00 04 Where the second bit is "open load". So this would fail the test. So in the kcontrol case the test would be something like: amixer sset "AMP1 turn on diagnostic" on amixer sget "AMP1 diagnostic" And the module parameter case: rmmod tda7802 modprobe tda7802 turn_on_diagnostic=1 dmesg | grep "Turn on diagnostic 04 04 04 04" rmmod tda7802 modprobe tda7802 I think the module parameter method is more appropriate for a "Turn-on diagnostic", even though I don't really like grepping dmesg for the result. I'll go ahead and implement that unless anyone has a particular preference for the kcontrol-trigger. Thanks