Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751327AbVLKKtO (ORCPT ); Sun, 11 Dec 2005 05:49:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751339AbVLKKtO (ORCPT ); Sun, 11 Dec 2005 05:49:14 -0500 Received: from gold.veritas.com ([143.127.12.110]:61497 "EHLO gold.veritas.com") by vger.kernel.org with ESMTP id S1751327AbVLKKtN (ORCPT ); Sun, 11 Dec 2005 05:49:13 -0500 Date: Sun, 11 Dec 2005 10:49:24 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@goblin.wat.veritas.com To: Brice Goglin cc: Martin Drab , Linus Torvalds , Linux Kernel Mailing List Subject: Re: Linux 2.6.15-rc5 bad page with fglrx on Radeon X300 In-Reply-To: <439B475F.2050901@ens-lyon.org> Message-ID: References: <439B475F.2050901@ens-lyon.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 11 Dec 2005 10:49:08.0744 (UTC) FILETIME=[837F3080:01C5FE40] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1427 Lines: 31 On Sat, 10 Dec 2005, Brice Goglin wrote: > Does anybody out there have ATI drivers working on Radeon X300 > on 2.6.15-rc5 (or -rc[234]) ? They released fglrx 8.20.8 on december 8th. > I thought they would have fixed the driver for 2.6.15. > But, I still get bad page and X programs freezing. The ATI wrapper source is carefully "#if 0"ing a get_page because of the traditional anomalous behaviour of PageReserved. 2.6.15-rc killed that anomalous behaviour, so their "#if 0" needs to become a version test. Big thanks to Martin Drab for testing this (and correcting the stupidity of my original inverted patch) - tell us if it does not work for you too. Hugh --- fglrx.orig/build_mod/firegl_public.c 2005-12-05 15:47:41.000000000 +0000 +++ fglrx/build_mod/firegl_public.c 2005-12-05 17:18:12.000000000 +0000 @@ -2586,7 +2586,7 @@ static __inline__ vm_nopage_ret_t do_vm_ pMmPage = virt_to_page(kaddr); -#if 0 +#if LINUX_VERSION_CODE >= 0x02060f // WARNING WARNINIG WARNNING WARNNING WARNNING WARNNING WARNNING WARNNING // Don't increment page usage count, cause ctx pages are allocated // with drm_alloc_pages, which marks all pages as reserved. Reserved - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/