Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 2 Aug 2019 16:21:58 +0100
From:   Qais Yousef <qais.yousef@arm.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     mingo@kernel.org, linux-kernel@vger.kernel.org,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/5] Fix FIFO-99 abuse
Message-ID: <20190802152157.7fp775lg7tbm5rec@e107158-lin.cambridge.arm.com>
References: <20190801111348.530242235@infradead.org>
 <20190801131707.5rpyydznnhz474la@e107158-lin.cambridge.arm.com>
 <20190802093244.GF2332@hirez.programming.kicks-ass.net>
 <20190802102611.54sae3onftck5fye@e107158-lin.cambridge.arm.com>
 <20190802124151.GG2332@hirez.programming.kicks-ass.net>
 <20190802140854.ixq4cmo5nsfdaj24@e107158-lin.cambridge.arm.com>
 <20190802143324.GH2332@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190802143324.GH2332@hirez.programming.kicks-ass.net>
User-Agent: NeoMutt/20171215
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/02/19 16:33, Peter Zijlstra wrote:
> > > Also also, RR-SMP is actually broken (and nobody has cared enough to
> > > bother fixing it).
> > 
> > If you can give me enough pointers to understand the problem I might be able to
> > bother with it :-)
> 
> So the push-pull balancer we have (designed for FIFO but also applied to
> RR) will only move a task if the destination CPU has a lower prio.  In
> the case where one CPU has 3 tasks and the other 1, and they're all the
> same prio, it does nothing.  For FIFO that is fine, for RR, not so much.
> 
> Because then the one CPU will RR between 3 tasks, giving each task
> 1/3rd, while the other will only run the one task.

Okay so what we need to do is keep a count of number of RR tasks on each CPU
(which we already do IIRC) and take that into account in
find_loweset_rq()/cpupri_find().

Let me see if I can create a test case then hack something.

Thanks

--
Qais Yousef