Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp723172ybh; Sat, 3 Aug 2019 08:26:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWDo5piJedBaIsI9gPVl0QWs4OyrQurgEFeCPwBO10P7u4vitT/vQwhSlIqXJIS3OO/DNw X-Received: by 2002:a17:90a:b387:: with SMTP id e7mr9995304pjr.113.1564845991220; Sat, 03 Aug 2019 08:26:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564845991; cv=none; d=google.com; s=arc-20160816; b=WBrrltRA7HUQqpc1FXSyEo/Lzem75oXHP5MfPwfMKONekbEZ0L/4WVrAzuNkhnsqMX k95t6Ywalg8Lh6EsQZ/I3dYLiYEypVUzzx6KdrNzJQaqSRycKCjRccalMOFIgSeIMKsI 7MCr7Pfc3Qnw+eWSW/VPHufC+OWe0mPOqgGtdcfoRVxYAPmQLXiXeID6CWfe3D06ndED TztUSBQYiSfShXqs8WKYcL53/7jJLfbPxeqy/p7ebX80qAh/RG8Fr1K3oD/GXzbaCScW rcOdX63z7wjdZ5SUN0Dk2JC3u4RLGPMknR+Yk2uk7bAaGRwRNPodaZ1/xF70Nx2LCY0I Mm1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=kFfF3DsSbGyIc2CCgLuIBVK5Am+sUDpweYOfEsnGXsc=; b=tnxb3heQJegC47bss6p0RNzhGUxcxIGUEQza8tBZJZA9jUObbKfMaD5YNg8gPrwXWO A8mTuYFk8QqkjZ7+2H9W6XhrxaR31Y2Ro5Ljzy2betpV4gbINFO2w/pR8OQqq4VDHLm0 m8ANNhVE9WXP8CefrjL+sZwmGSv86ch2CIi72aaCF4n2GpW53nlKHdNZDX7RyIq7z2Es XYK1HB5Hec5Z3KP5pM1C/QHuymOc4gX5komR2nR+kBBVV2wuCzK9hcbdEdXCrTOMV+iQ hR9z2jhSres3ut4aOLPDG4G/h3FVDttdcC8nTGVeJoUFMXwPJ5gRnnNHNRCdyta1DU3M eEiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="w9lC7d/J"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f74si40174910pfa.57.2019.08.03.08.26.15; Sat, 03 Aug 2019 08:26:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="w9lC7d/J"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391266AbfHBQck (ORCPT + 99 others); Fri, 2 Aug 2019 12:32:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:58816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391044AbfHBQck (ORCPT ); Fri, 2 Aug 2019 12:32:40 -0400 Received: from tleilax.poochiereds.net (cpe-71-70-156-158.nc.res.rr.com [71.70.156.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C6B4A2087E; Fri, 2 Aug 2019 16:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564763559; bh=1dY9dkZC8/0rNIVNPhWlmJIGw2Fn+nke+Cx8Y2WqslE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=w9lC7d/J2b2evJ3hdfblytM+pyTOBE5/6j/xetCh1lnfVbAKbgleAivNvwuv+cK+I juOFzY+Rq5aV9tnRvib3kGBa/z6jlMrK1IN4ONnBBuq1OVB8IUcUL3WnQd2pcxMRna m5sZdGkNIZrGL3/J2MK86MjLYi2o6z5PRXqYVpww= Message-ID: <89f2fdcbd007dcf6bb2b01772a17eb63459cac9d.camel@kernel.org> Subject: Re: [PATCH] fs/ceph: don't return a value from void function From: Jeff Layton To: john.hubbard@gmail.com Cc: Sage Weil , Ilya Dryomov , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, John Hubbard Date: Fri, 02 Aug 2019 12:32:37 -0400 In-Reply-To: <20190802010658.18150-1-jhubbard@nvidia.com> References: <20190802010658.18150-1-jhubbard@nvidia.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-08-01 at 18:06 -0700, john.hubbard@gmail.com wrote: > From: John Hubbard > > This fixes a build warning to that effect. > > Signed-off-by: John Hubbard > --- > > Hi, > > I ran into this while working on unrelated changes, to > convert ceph over to put_user_page(). > > This patch is against the latest linux.git. > > thanks, > John Hubbard > NVIDIA > > > fs/ceph/debugfs.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c > index 2eb88ed22993..facb387c2735 100644 > --- a/fs/ceph/debugfs.c > +++ b/fs/ceph/debugfs.c > @@ -294,7 +294,6 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc) > > void ceph_fs_debugfs_init(struct ceph_fs_client *fsc) > { > - return 0; > } > > void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc) Thanks. Merged into ceph-client/testing branch, we'll see about getting this to Linus before v5.3 ships. -- Jeff Layton