Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp765032ybh; Sat, 3 Aug 2019 09:18:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwD58k8GquDZbIQ/h7+ZRUpQa1XBRl5K6g86DKTuuT2MHU28dywNiOGY3/4a6mqOJT2/hEp X-Received: by 2002:a17:902:b48c:: with SMTP id y12mr101632807plr.202.1564849113918; Sat, 03 Aug 2019 09:18:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564849113; cv=none; d=google.com; s=arc-20160816; b=pa84B/Aw+tnLLFi9hjKjSDANKCd0Ppz+3mFdevbInvDFBm+e4NRaW1TJdIw7gkl4tu MhUCfuZ2pGwbpHh5olxRMJSvlIpU64Jo0yJSrd6kR+o5B4xMKN2wX+OfRKRWL6ujV652 3dmOh1XmXPAZa0aFo2Q0SmxEKmk/yetUHiIeZtSC4fU8XuOU8E6yfpED4tJ/XwH/HVwT U6Sf4FdPtQBuwgantqH5Wz9uCQMFgGh/T9BnxHx+BAo9IV9+VS81Ss8Um6PYAVdaEgaV vMbF9FogBhA4Iaavm+hfCSVAqnM6JzLWacOBsJY0k4u1tLnOtimI8cFR09L0s0KOEjyq fSHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Q8q3tf3Va+keHKxayzPooBGCx3OThztT6FtIpqAhK/0=; b=wcg/R8TMbkRAeGnLz9s+WkBnj7LcuwNq9U6SEDjM9EYq06fdFwX7N9MsozGFM8mfqh mPZeuS6kXGpSqB96C0/wTbTjoArGZ36E48QLgVOOdSR9FDGPZEsJAeJzkGfz6C2h7b38 8cEk1mGuKJZRdONpFnxBnrfZgiWddsS9e6l06k0L5F0t1kSM/Fw+bVOv+1C2RH90YPsi iAgi8iqmSEIsA06ZXBE3APHfddOPYz19o44fG+KEmwuxL2LLvQJkwlxm7qTQhTEe9Vjb M6O8VSiuvlhv0eMo/rfsc410z5RbMIi7cHKmihjRepQEQzofarR+ZPZ0po/v5i6U6eMo V+kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E+tR6OQh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a94si8603287pje.19.2019.08.03.09.18.18; Sat, 03 Aug 2019 09:18:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E+tR6OQh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391825AbfHBRUV (ORCPT + 99 others); Fri, 2 Aug 2019 13:20:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:42316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388134AbfHBRUU (ORCPT ); Fri, 2 Aug 2019 13:20:20 -0400 Received: from localhost (unknown [106.51.106.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31F5820B7C; Fri, 2 Aug 2019 17:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564766420; bh=wff88TISwv4kNTmhGtyEipuGD0E7PUtarxD7H8iS0SE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E+tR6OQhKe0wWMRkqMN6KQnpI/DTVmFk6QzZqPkddtBsUHhvPPUzYN6L8BR3jPuE7 tcbJ8KWr5Pf3vlSnPQyz0HzUkzARjcEJhXYa5Pzhwt/rmTqufeydN74lJ4yrTyCyil 9WrtKkDgs504UqUzV6oeNBXNtRGaE4bgLCGLtAF4= Date: Fri, 2 Aug 2019 22:49:06 +0530 From: Vinod Koul To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Rander Wang , Sanyog Kale Subject: Re: [RFC PATCH 26/40] soundwire: cadence_master: fix divider setting in clock register Message-ID: <20190802171906.GB12733@vkoul-mobl.Dlink> References: <20190725234032.21152-1-pierre-louis.bossart@linux.intel.com> <20190725234032.21152-27-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190725234032.21152-27-pierre-louis.bossart@linux.intel.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25-07-19, 18:40, Pierre-Louis Bossart wrote: > From: Rander Wang > > The existing code uses an OR operation which would mix the original > divider setting with the new one, resulting in an invalid > configuration that can make codecs hang. This looked fine but fails to apply, feel free to send as a fix -- ~Vinod