Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp1178783ybh; Sat, 3 Aug 2019 19:55:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwk7wt9YeT2yM76/GjKYtgHuQePyifAEIiIaosLQj0GKJziLikWgQbta95g+J10w+pPJI4g X-Received: by 2002:a63:d84e:: with SMTP id k14mr131164794pgj.234.1564887299922; Sat, 03 Aug 2019 19:54:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564887299; cv=none; d=google.com; s=arc-20160816; b=xAhl24D4uT1TBYTtQeAbq/yIIsb5WOTsmjl2pLwnrOIOXHwXDJhdixrAwnocOnumHc AetoFN1E/RZ9KI0SyJH6YOmiBHH1cJf9M9+A3Nw49LiPFABmZWlo5u1EbtWhDVJwGmOZ c/DAbJIrWOAkKn71Zi9VwYcO09HGfNmrD5dQWt3a0c3YdHK8yJeoe43qcH+CTra5R5Sb 53K+7WkERRZHBXVWIHftBYc9fiv3/pitsVs1YCcbgpVm1QvUpXzrzsMT+F+bvxO31iy4 V8MHvTayBb+9B1faNdiLV8mfEaHlemv3feV4Zr1WeU4+Slo41NhD/b/V46NkBJpXEB8K D2MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=6oW3c7a6/d1sWvGuO36IJ6EW37+50pnAZgpBWIenH6Q=; b=isNO1BoL2gP9/gvyDG5d6thwbZJ5aC9Dn02WG2pBiny2ix5YdNPcXvwp+hxEAj98hX aqy+ZZDtzl7dlsEBqYKZkrNT9mVWzQbzSdbU7cjYTdd8n6ApHFKKm6TAYOQsVPVaMNO3 gDMmHOe1bsB3lkdm186/x/1igxEnvlYSgqrZjlDFVharAlmkbn9bbN4d7zGPxeWuQE31 ploPcjtk6k7xM6PNG2FhagHPqp0h9m9fql0SA0RYMr1h/xm/U/k1dG+7vONuiTmC+UwD VOrMVNacR4cSlAoqvcLSJ4gX+t26ljbq1rZ4owQzRUwJK/o2sSNPaYt0us/0mQbbo+EW KAVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t18si36547865plo.328.2019.08.03.19.54.45; Sat, 03 Aug 2019 19:54:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394949AbfHBUlt (ORCPT + 99 others); Fri, 2 Aug 2019 16:41:49 -0400 Received: from mga17.intel.com ([192.55.52.151]:4241 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726305AbfHBUlt (ORCPT ); Fri, 2 Aug 2019 16:41:49 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2019 13:41:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,339,1559545200"; d="scan'208";a="178255267" Received: from psathya-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.36.242]) by orsmga006.jf.intel.com with ESMTP; 02 Aug 2019 13:41:43 -0700 Date: Fri, 2 Aug 2019 23:41:42 +0300 From: Jarkko Sakkinen To: Alexander Steffen Cc: Stephen Boyd , Peter Huewe , Andrey Pronin , linux-kernel@vger.kernel.org, Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , linux-integrity@vger.kernel.org, Duncan Laurie , Guenter Roeck Subject: Re: [PATCH v2 5/6] tpm: add driver for cr50 on SPI Message-ID: <20190802204131.pcb73zq7gllyy3ul@linux.intel.com> References: <20190716224518.62556-1-swboyd@chromium.org> <20190716224518.62556-6-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 17, 2019 at 02:00:06PM +0200, Alexander Steffen wrote: > Is it a common pattern to add config options that are not useful on their > own? When would I ever enable TCG_CR50 without also enabling TCG_CR50_SPI? > Why can't you just use TCG_CR50_SPI for everything? Agreed. If the kernel only has the spi driver, we only want option for that. /Jarkko