Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 7/7] tracing: Un-export ftrace_set_clr_event
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org, Joe Jin <joe.jin@oracle.com>,
        Aruna Ramakrishna <aruna.ramakrishna@oracle.com>,
        Srinivas Eeda <srinivas.eeda@oracle.com>
References: <1564444954-28685-1-git-send-email-divya.indi@oracle.com>
 <1564444954-28685-8-git-send-email-divya.indi@oracle.com>
 <20190729205138.689864d2@gandalf.local.home>
 <8e50d405-a4fb-fadf-509e-157b031d7542@oracle.com>
 <20190802134229.2a969047@gandalf.local.home>
 <291a12f6-e1eb-052e-0dd6-0e649dd4a752@oracle.com>
 <20190802164641.46416744@gandalf.local.home>
From:   Divya Indi <divya.indi@oracle.com>
Message-ID: <87e1a9b8-9f72-c240-9b9a-2d454046e2f3@oracle.com>
Date:   Fri, 2 Aug 2019 14:12:54 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190802164641.46416744@gandalf.local.home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Steve,

The first patch would be like a temporary fix in case we need more 
changes to the patches that add the new function - trace_array_set_clr() 
and unexport ftrace_set_clr_event() and might take some time. In which 
case I think it would be good to have this in place (But, not part of 
this series).

If they all are to go in together as part of the same release ie if all 
is good with the concerned patches (Patch 6 & Patch 7), then I think 
having this patch would be meaningless.


Thanks,

Divya

On 8/2/19 1:46 PM, Steven Rostedt wrote:
> On Fri, 2 Aug 2019 13:41:20 -0700
> Divya Indi <divya.indi@oracle.com> wrote:
>
>>> As a stand alone patch, the first one may be fine. But as part of a
>>> series, it doesn't make sense to add it.
>> I see. Will separate this out from the series.
> Is that really needed? Do you need to have that patch in the kernel?
>
> Do you plan on marking it for stable?
>
> -- Steve