Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp1202787ybh; Sat, 3 Aug 2019 20:31:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqxs3oAk81O0Uk0SVsfybJwWBXs/43X68leKbFEwnTLigEaUHG2R5WBP4P8Sa2M+fZ2iSXWL X-Received: by 2002:a17:902:a514:: with SMTP id s20mr131033331plq.162.1564889484941; Sat, 03 Aug 2019 20:31:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564889484; cv=none; d=google.com; s=arc-20160816; b=hAx9df27goIl9gOXna/DkqkhQJwEK6ZKU1Glw7D3DlaCiEsV20m31eXKPHGiavqOXs Us30Cq0y0KXMMD52YjqT0fgNbzzBZX1HWlVkgXKvGU6JKTvALWi6fzZbh+ea35KqhbRa VAfd5bDVE+GHYZBcRyphJs06zp87BEsAcTjU7wpdIyNwWibUZ8kwvMySyABvqA7P9Pa4 cD69PIVHT+tsYMvKixB3PgA4/Gu/rrzlzW4rNRKki3auEH77YE65N5CvLqaIx+QkYjf8 SUAk0nFCNfYFGNHyi4aN0f3E2fGHx5Vg4k7rcJAc1N2qNpgkZDwRYASmdKL/N2+jWpYp moyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4AmPCO4nvCTMmb65MIbwdeCdWMXKZXu029jmF/IGbGk=; b=DRGKknBOFWuTwymNb0I3OXtFTGcw5RWCc7F8Bv6ZvkE9q1ufh4YsGJkeWuD5oEHwKB UBdlACquPpD3Swnohh5MMvG8a7QqiZolGE9patgTr//Rl3lqX+SKqN5CH6zq0kKRPovi 0Tb/Bz4JN1O3UVx8Wd+IVC4o32OnxxVwaCruLhKVCiMznRkV6vaWPkqWYPzrhyy2DTrY Gyh7ELbA0TaJNC0RCgEBAQb9GRUykr5Wh/ud9+6x2thIYV7enWfH9suyNxLeEbCMerxL rV+SJ0VflQdN5jgrt+z2Ou0C1UzcqMSRrvgY42TXzGINgBG2hLH9Iubbvjigm4i4yrX4 Shpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="lh1FEk9/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id az7si9607934pjb.51.2019.08.03.20.31.09; Sat, 03 Aug 2019 20:31:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="lh1FEk9/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbfHCGcu (ORCPT + 99 others); Sat, 3 Aug 2019 02:32:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:58642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726797AbfHCGct (ORCPT ); Sat, 3 Aug 2019 02:32:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 664302087C; Sat, 3 Aug 2019 06:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564813968; bh=5uFzZfIoEwQBrWrcs4j9f2dtR+4Xisp4P+uNFPPnC6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lh1FEk9/Jhz2/FN/OK8/GklDYDO8dc7O27K+G/TM8SPQnlKeRzAsGlwtG6uVw+qtN 3tICWpwn5LR5OKXCOUHPFxPOnmUYdg0imvF3gHaOrzXYryouxEkoLrhMfwau/m7b2p x7AmU1cHO6IqPw1+USVh/Dzh7aeHb5sEG5N9pInk= Date: Sat, 3 Aug 2019 08:32:46 +0200 From: Greg KH To: Jose Carlos Cazarin Filho Cc: isdn@linux-pingi.de, devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] isdn: hysdn: Fix error spaces around '*' Message-ID: <20190803063246.GA10186@kroah.com> References: <20190802195602.28414-1-joseespiriki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802195602.28414-1-joseespiriki@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 02, 2019 at 07:56:02PM +0000, Jose Carlos Cazarin Filho wrote: > Fix checkpath error: > CHECK: spaces preferred around that '*' (ctx:WxV) > +extern hysdn_card *card_root; /* pointer to first card */ > > Signed-off-by: Jose Carlos Cazarin Filho > --- > Hello all! > This is my first commit to the Linux Kernel, I'm doing this to learn and be able > to contribute more in the future > Peace all! > > drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h > index cdac46a21..f20150d62 100644 > --- a/drivers/staging/isdn/hysdn/hysdn_defs.h > +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h > @@ -220,7 +220,7 @@ typedef struct hycapictrl_info hycapictrl_info; > /*****************/ > /* exported vars */ > /*****************/ > -extern hysdn_card *card_root; /* pointer to first card */ > +extern hysdn_card * card_root; /* pointer to first card */ The original code here is correct, checkpatch must be reporting this incorrectly. thanks, greg k-h