Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp1203653ybh; Sat, 3 Aug 2019 20:32:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqyet43bt2JqfCvsu0Urv0lz3XUDHiSFYLqzKhPFfWNmwK8URz6ycobGpvXkvS2FUUeH7Jga X-Received: by 2002:a63:2026:: with SMTP id g38mr124720416pgg.172.1564889553861; Sat, 03 Aug 2019 20:32:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564889553; cv=none; d=google.com; s=arc-20160816; b=e4R2pK9DA5mtkX0YqSPWj5C3XYRATg1QgKRvQJFzI0zVfREA2KgoAN4VUnpK5jlJLr r4yv5MiEGQDoy8/TolS/XRbY7uP/WNsMdUcrF1cPt7qj7K7mi3dKux/d16AxSGGJbLc6 Eltj1NZu18fB/L77GN1mtsZeeq612kXFXy4//2CJRXbUyES4yF9SKc66uk2B6fdYe/L4 CgsdAjEhePKzidTfRcHxHGo9jG1roExSW+XdBVoqhEyTpjSShB7VYVQwBWLPQEt8X/7V /HIpX2sjqznMkuufPDA35oxv9iZ50CAIcKWnXC6x5awgsvSXejKBcPDq8gnqBVq1cMnP GZGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lOEmndmw7qAWg9EwA5b4A1GhkzV3P9GC38XUe++nXvM=; b=Szoi5yGwmbrZqaPPS5hmKBMlwNm6n4xpCQFoaog1iPvvdqa0jrMryfNV61yuqXd3Dj 1eHO8EUCVjDKe+Uio6/9w7wcX14Nz4IQ2Yp0gGDLJ77X2lZvANrF932QUjapndsET37O iPlV9YQm2hzH4cv6BTwiHBTcs3T1Qohnaihhb3A/vygQ6n2GbUf1P4T4t3xLPIPhrwOV 2f/ckUnStBV4F1/PhVHtb6cZJTI3/4gCjaVQcFqJVdpdLiN0rK9Vpz8JvgYWlqyM3/YZ Ltf0iu1pT321VbsU5z9678xS37/AEau4LNvBPsO+qxUJwwAs2IBz7Pub6O03PE2DRK87 BrXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vWTFmpNi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t35si15183245pgm.8.2019.08.03.20.32.18; Sat, 03 Aug 2019 20:32:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vWTFmpNi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbfHCHAn (ORCPT + 99 others); Sat, 3 Aug 2019 03:00:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:38408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726797AbfHCHAn (ORCPT ); Sat, 3 Aug 2019 03:00:43 -0400 Received: from X250 (cm-84.211.118.175.getinternet.no [84.211.118.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B039C206A2; Sat, 3 Aug 2019 07:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564815641; bh=Mx/SnMcesaBhJ/+1aNzTVEStgY0PLbFq0Cn9fzUKZFI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vWTFmpNiA2iV7ZADM/jQQhVG5dxH6s50eBykNukiLwZrXMbI2ko+4YJkraKc9h4yW gT+yK/FSFzC75LF3yqEeynkMqLQyXvE33dYZLg1buqojNtCOFSu2Dvxvg+bslfwk7h Twg4iLQQdO3eXemoEAKcsbTuppqe/TK1g5ve9Ot8= Date: Sat, 3 Aug 2019 09:00:34 +0200 From: Shawn Guo To: Yinbo Zhu Cc: Li Yang , Rob Herring , xiaobo.xie@nxp.com, Mark Rutland , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, yangbo.lu@nxp.com, jiafei.pan@nxp.com, Ashish Kumar Subject: Re: [PATCH v3] arm64: dts: ls1028a: Add esdhc node in dts Message-ID: <20190803070033.GA5627@X250> References: <20190515084925.30155-1-yinbo.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515084925.30155-1-yinbo.zhu@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 04:49:25PM +0800, Yinbo Zhu wrote: > From: Ashish Kumar > > This patch is to add esdhc node and enable SD UHS-I, > eMMC HS200 for ls1028ardb/ls1028aqds board. > > Signed-off-by: Ashish Kumar > Signed-off-by: Yangbo Lu > Signed-off-by: Yinbo Zhu > --- > Change in v3: > replace "esdhc@" with "mmc@" > > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 8 ++++++ > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 13 ++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 27 +++++++++++++++++++++ > 3 files changed, 48 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index 14c79f4..180e5d2 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -42,6 +42,14 @@ > status = "okay"; > }; > > +&esdhc { > + status = "okay"; > +}; > + > +&esdhc1 { > + status = "okay"; > +}; > + > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > index f86b054..1bfaf42 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts > @@ -30,6 +30,19 @@ > }; > }; > > +&esdhc { > + status = "okay"; We usually put 'status' at end of property list. > + sd-uhs-sdr104; > + sd-uhs-sdr50; > + sd-uhs-sdr25; > + sd-uhs-sdr12; > + }; Please follow the indent style of closing parentheses in the file. > + > +&esdhc1 { > + status = "okay"; > + mmc-hs200-1_8v; > + }; Ditto > + > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 2896bbc..462833c 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -274,6 +274,33 @@ > status = "disabled"; > }; > > + esdhc: mmc@2140000 { Please sort the nodes in unit-address. From what I see, it should go before device serial@21c0500. > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; > + reg = <0x0 0x2140000 0x0 0x10000>; > + interrupts = <0 28 0x4>; /* Level high type */ Use IRQ_TYPE_LEVEL_HIGH, then you can drop the comment. Shawn > + clock-frequency = <0>; /* fixed up by bootloader */ > + clocks = <&clockgen 2 1>; > + voltage-ranges = <1800 1800 3300 3300>; > + sdhci,auto-cmd12; > + little-endian; > + bus-width = <4>; > + status = "disabled"; > + }; > + > + esdhc1: mmc@2150000 { > + compatible = "fsl,ls1028a-esdhc", "fsl,esdhc"; > + reg = <0x0 0x2150000 0x0 0x10000>; > + interrupts = <0 63 0x4>; /* Level high type */ > + clock-frequency = <0>; /* fixed up by bootloader */ > + clocks = <&clockgen 2 1>; > + voltage-ranges = <1800 1800 3300 3300>; > + sdhci,auto-cmd12; > + broken-cd; > + little-endian; > + bus-width = <4>; > + status = "disabled"; > + }; > + > sata: sata@3200000 { > compatible = "fsl,ls1028a-ahci"; > reg = <0x0 0x3200000 0x0 0x10000>, > -- > 1.7.1 >