Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Stefan-gabriel Mirea <stefan-gabriel.mirea@nxp.com>
To:     Rob Herring <robh+dt@kernel.org>
CC:     "corbet@lwn.net" <corbet@lwn.net>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        Leo Li <leoyang.li@nxp.com>,
        "jslaby@suse.com" <jslaby@suse.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Eddy Petrisor <eddy.petrisor@nxp.com>
Subject: Re: [EXT] Re: [PATCH 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB
 board
Thread-Topic: [EXT] Re: [PATCH 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB
 board
Thread-Index: AQHVSWsWLPLKyRuIh0CSHJAAi/FmUA==
Date:   Sat, 3 Aug 2019 08:00:31 +0000
Message-ID: <VI1PR0402MB28635B9758CBF72504191693DFD80@VI1PR0402MB2863.eurprd04.prod.outlook.com>
References: <20190802194702.30249-1-stefan-gabriel.mirea@nxp.com>
 <20190802194702.30249-2-stefan-gabriel.mirea@nxp.com>
 <CAL_JsqL++GZBxczxePni9ysNq06kObB4EzJEi1e4M=PurPZFgQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 651eb805-28b5-4f93-791a-08d717e8a804
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2019 08:00:31.3062
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: stefan-gabriel.mirea@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3821
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Rob,=0A=
=0A=
On 8/3/2019 1:38 AM, Rob Herring wrote:=0A=
> On Fri, Aug 2, 2019 at 1:47 PM Stefan-gabriel Mirea=0A=
> <stefan-gabriel.mirea@nxp.com> wrote:=0A=
>> +      - description: S32V234 Customer Evaluation Board=0A=
>=0A=
> Most of the entries in this file are for all the boards for an SoC.=0A=
>=0A=
>> +        items:=0A=
>> +          - enum:=0A=
>> +              - fsl,s32v234-evb=0A=
>=0A=
> If that's not going to be the case here, you can use 'const' here.=0A=
=0A=
We also intend to submit patches for the SBC-S32V234[1] board in the=0A=
future and I believe that its 'compatible' should share this entry.=0A=
Would it therefore be preferable to update the description at this=0A=
moment and add a comment, like:=0A=
=0A=
      - description: S32V234 based Boards=0A=
        items:=0A=
          - enum:=0A=
              - fsl,s32v234-evb           # S32V234-EVB2 Customer Evaluatio=
n Board=0A=
          - const: fsl,s32v234=0A=
=0A=
or just replace the single-value 'enum' with a 'const' for now?=0A=
=0A=
Regards,=0A=
Stefan=0A=
=0A=
[1] https://www.nxp.com/design/development-boards/automotive-development-pl=
atforms/s32v-mpus-platforms/s32v-vision-and-sensor-fusion-evaluation-board:=
SBC-S32V234=0A=